Skip to content

allow using lazy loadable renderers in angular #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dsl400
Copy link
Contributor

@dsl400 dsl400 commented May 11, 2025

proposal to add possibility to use lazy loadable renderers

Copy link

netlify bot commented May 11, 2025

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 5e32b15
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/6820b7fe3b08cd000806ce7f
😎 Deploy Preview https://deploy-preview-2446--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented May 11, 2025

CLA assistant check
All committers have signed the CLA.

@dsl400 dsl400 changed the title allow using lazy loadable renderers allow using lazy loadable renderers in angular May 11, 2025
@coveralls
Copy link

Coverage Status

coverage: 82.517%. remained the same
when pulling 5e32b15 on dsl400:master
into 6637fb0 on eclipsesource:master.

@lucas-koehler
Copy link
Contributor

Hi @dsl400 ,
thanks for the contribution!
What is you use case for this change? Usually, the number of renderers should be small enough to load them synchronously.
I ask because I'm a bit concerned that an asynchronous update method might lead to race conditions when being invoked frequently by the state subscription added in ngOnInit.

@dsl400
Copy link
Contributor Author

dsl400 commented May 12, 2025

I was hoping to migrate our existing code by loading some components as custom renderers until we have time to create schema for all our existing forms

@sdirix
Copy link
Member

sdirix commented May 13, 2025

I don't think this PR is necessary. Instead of within JSON Forms you could await the renderers outside of JSON Forms and only render JSON Forms once they are resolved.

@dsl400
Copy link
Contributor Author

dsl400 commented May 13, 2025

I don't think this PR is necessary. Instead of within JSON Forms you could await the renderers outside of JSON Forms and only render JSON Forms once they are resolved.

Can you provide some technical arguments about why ?
Maybe it is something that I do not yet understand.

My argument is: It has no impact on existing functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants