Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the Peak List by default #1932

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Mailaender
Copy link
Contributor

@Mailaender Mailaender commented Nov 5, 2024

but focus the Data Explorer because people need to open their files first. The rationale is that the Peak List is far too important to hide in the most crowded toolbar menu. Since #1549 we have more vertical space to allow for a fourth tab.

@eselmeister
Copy link
Contributor

In a first try, I stumbled and wondered why I'm not able to activate the peaks list part even though its header is visible. In a second look I saw, the the focus is set on the data explorer. I'm not sure, if this more helps or confuses the customers. I was also confused.

@Mailaender
Copy link
Contributor Author

When I keep its default focus, people will see an empty peak list when opening the Data Analysis view for the first time and then complain that they don't know how to open files or use the awkward ways from the Files menu instead.

@eselmeister
Copy link
Contributor

The *.e4xmi "Position in list:" option allows to place items via keywords before or after a specific part, e.g.:
after:org.eclipse.chemclipse.ux.extension.xxd.ui.part.dataexplorer

image

But I also need to have a look if that is possible here, as the part is created dynamically.

@Mailaender
Copy link
Contributor Author

Looks like this for me:
grafik
Changing Selected Element had no effect.

@eselmeister eselmeister merged commit faaefa2 into eclipse:develop Nov 14, 2024
3 checks passed
@Mailaender Mailaender deleted the default-peak-list branch November 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants