Adding sys prop to enable heap pools with JDK SSL #5316
Conversation
|
@cescoffier and @vietj PTAL I've added some asserts to make it existing tests to fail and make sure the invariant I'm assuming for SSL on vertx are correct. |
| @@ -57,6 +61,40 @@ public class SSLHelper { | |||
| CLIENT_AUTH_MAPPING.put(ClientAuth.NONE, io.netty.handler.ssl.ClientAuth.NONE); | |||
| } | |||
|
|
|||
| ByteBufAllocator clientByteBufAllocator(SslChannelProvider sslChannelProvider) { | |||
| assert sslChannelProvider != null && sslChannelProvider.sslContextProvider() != null && | |||
There was a problem hiding this comment.
@vietj these are here to compensate to lack of tests here: these should fail in the CI even if the sys prop is not used, so we know that the assumption, while enabled, is broken
|
@cescoffier this is key for both https and vertx sql client - cause the latter will rely heavily on it for the reactive sql drivers (both mysql and postgres AFAIK) - @tsegismont AFAIK vertx sql driver should rely on |
|
After talking with @cescoffier I'm changing this back to use a specific option to enable this feature. |
SSL JDK can really be a memory hell, see netty/netty#14208: using unpooled buffers means trouble - but still there are users which "maybe" want to keep things as they are.
I've created an "hidden" property (which should become the default in vertx 5 really...) to have forcibly pooling of heap buffers using JDK SSL, but, by default it will keep the behaviour as it is.