Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5049 fix pipe race condition #5050

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

5049 fix pipe race condition #5050

wants to merge 2 commits into from

Commits on Dec 22, 2023

  1. eclipse-vertx#5049 fix Pipe's race condition 

    Fix issue: eclipse-vertx#5049

Signed-off-by: Nils Renaud <[email protected]>
    @NilsRenaud
    NilsRenaud committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    3bb8d6c View commit details
    Browse the repository at this point in the history

  2. Fix a broken test in PipeTest 

    PipeTest#testFailStreamPrematurely was failing because the error handler is now activated before receiving the first element of the read stream.

But, I think that's an error in the FakeStream implementation which calls the failure handler immediately, bypassing the content delivery.
This means that the previous FakeThread implementation permitted:
- multiple failure handler calls on the same Stream
- A failure event THEN a new element read
This, IMO does not respect the ReadStream behaviour.

This test was only OK because the failure handler was set after the call to resume in the Pipe implementation. But it looks like a tweak to accommodate with the buggy FakeStream behavior.

Signed-off-by: Nils Renaud <[email protected]>
    @NilsRenaud
    NilsRenaud committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    f0cb637 View commit details
    Browse the repository at this point in the history