Skip to content

Add possibility to register ContentCodec with scheme #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
danielpeintner wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add possibility to register ContentCodec with scheme #1412

danielpeintner wants to merge 2 commits into from

Conversation

@danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Aug 19, 2025

TODO calls for contentToValue and valueToContent need to provide scheme

fixes #1409

@danielpeintner
refactor: add possibility to register ContentCodec with scheme
76202f9 
TODO calls for contentToValue and valueToContent need to provide schema
@danielpeintner danielpeintner marked this pull request as draft August 19, 2025 12:39
@danielpeintner
Copy link
Member Author

danielpeintner commented Aug 19, 2025 •
edited
Loading

Note: The failing tests are in areas that haven't been touched and the error

Exception during run: SyntaxError[ @/home/runner/work/node-wot/node-wot/packages/binding-websockets/test/ws-tests.ts ]: Invalid or unexpected token

reminds me to what we have been seeing for Node.js 24.
see #1377 (comment)

Anyhow, the failures are coming from Node.js 22

@danielpeintner
Copy link
Member Author

danielpeintner commented Sep 5, 2025

FYI: Failing tests issue resolved by now.
I am interested to hear whether people think we should add such a possibility

@danielpeintner danielpeintner added the Discuss in Committer Meeting Labels issues and PRs that should be discussed in our regular Thingweb Committer Meeting. label Oct 27, 2025
@danielpeintner
Copy link
Member Author

danielpeintner commented Oct 29, 2025

Based on the OPC UA discussion, where it would be beneficial to have a specific application/octet-stream for OPC UA while keeping the generic one in place. Does it make sense to move forward with this PR?

The change is to extend the addCodec() method with an optional scheme parameter to take precedence...

@relu91 @erossignon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@relu91 relu91 Awaiting requested review from relu91 relu91 is a code owner

@JKRhb JKRhb Awaiting requested review from JKRhb JKRhb is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Discuss in Committer Meeting Labels issues and PRs that should be discussed in our regular Thingweb Committer Meeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow different Codecs for the same contentType

1 participant

@danielpeintner