Support "Save As" for custom editors #14972
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
plug-in system
msujew
force-pushed
the
msujew/fix-custom-editor-save-as
branch
from
57df82f to
d9a75e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #14966
Allows
Saveableinstances to implement their ownsaveAsroutine. This is required to fix saving for custom editors. All other editors can continue to just serialize their contents to use the generic "Save As" function.How to test
Follow the reproduction steps of #14966 and ensure that the "Save As" functionality works for both the
.pawDrawand.cscratchfiles.Review checklist
Reminder for reviewers