Skip to content

Commit

Permalink
Fix next build (#14981)
Browse files Browse the repository at this point in the history
Fixed the next build by updating the latest tag to be an annotated tag.
Adjusted the documentation to make this clearer.
Also fixed some versions that were left behind in the `lerna.json` an `@examples/playwright`.
Improved the Publishing guide for the native dependency steps.

Signed-off-by: Simon Graband <[email protected]>
  • Loading branch information
sgraband authored Feb 19, 2025
1 parent 4ffb744 commit 32ff943
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 315 deletions.
17 changes: 15 additions & 2 deletions doc/Publishing.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,11 @@ Format:

- Push the branch.

- Run the [_Package Native Dependencies_](https://github.com/eclipse-theia/theia/actions/workflows/native-dependencies.yml) GitHub Action on the new branch and download the artifacts.
- Get the `native dependencies`
- Run the [_Package Native Dependencies_](https://github.com/eclipse-theia/theia/actions/workflows/native-dependencies.yml) GitHub Action on the new branch (You can continue while you wait).
- Download the artifacts (They are located on the build overview at the bottom).
- Extract the downloaded folders.
- Leave the dependencies for now, you will need them later.

- Create a PR (not needed for patch releases):
- Name: `Theia {version}`.
Expand All @@ -182,6 +186,12 @@ Format:
git tag -a v{version} ${sha} -m "v{version}"
```

_Note_: The tag needs to be annotated otherwise it might break the publishing. Check that the output of the following command is `tag` and not `commit`.

```bash
git for-each-ref refs/tags | grep 'v1.58.0' | awk '{print $2}'
```

- Push the tag:

```bash
Expand All @@ -193,7 +203,10 @@ Format:
- Choose the appropriate `tag` and input a `name` (e.g., `v1.55.0`, `Eclipse Theia v1.55.0`).
- Use `generate release notes` for contributors and format like previous releases.
- Reference the `changelog` and breaking changes.
- Attach _Package Native Dependencies_ artifacts.
- Attach _Native Dependencies_ artifacts (the extracted zips).
- native-dependencies-darwin-arm64.zip
- native-dependencies-linux-x64.zip
- native-dependencies-win32-x64.zip
- Mark the release as `latest` (_Do not mark for a patch on an older version_).
- Select _"Publish Release"_.
- See [GitHub documentation](https://help.github.com/en/github/administering-a-repository/managing-releases-in-a-repository#creating-a-release) for details.
Expand Down
2 changes: 1 addition & 1 deletion examples/playwright/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"fs-extra": "^9.0.8"
},
"devDependencies": {
"@theia/cli": "1.55.0",
"@theia/cli": "1.58.0",
"@types/fs-extra": "^9.0.8",
"allure-commandline": "^2.23.1",
"allure-playwright": "^2.5.0",
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://json.schemastore.org/lerna.json",
"npmClient": "npm",
"version": "1.57.0",
"version": "1.58.0",
"command": {
"run": {
"stream": true
Expand Down
310 changes: 2 additions & 308 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 32ff943

Please sign in to comment.