Skip to content

[2174] Add the support for frame edge#2191

Open
gcoutable wants to merge 1 commit intomainfrom
gco/enh/frames-relationship
Open

[2174] Add the support for frame edge#2191
gcoutable wants to merge 1 commit intomainfrom
gco/enh/frames-relationship

Conversation

@gcoutable
Copy link
Copy Markdown
Member

@gcoutable gcoutable commented May 5, 2026 •
edited
Loading

Bug: #2174
Signed-off-by: Guillaume Coutable guillaume.coutable@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gcoutable gcoutable added this to the 2026.5.0 milestone May 5, 2026
@gcoutable gcoutable linked an issue May 5, 2026 that may be closed by this pull request
Add the support for the frame relationship #2174
Open
@gcoutable gcoutable force-pushed the gco/enh/frames-relationship branch 2 times, most recently from 3cfd8ed to b731063 Compare May 5, 2026 13:08
@gcoutable gcoutable marked this pull request as ready for review May 5, 2026 13:17
@gcoutable gcoutable requested a review from AxelRICHARD May 5, 2026 13:17
@gcoutable gcoutable force-pushed the gco/enh/frames-relationship branch 2 times, most recently from 4eb1fce to 0139c53 Compare May 5, 2026 14:00
AxelRICHARD
AxelRICHARD reviewed May 5, 2026
View reviewed changes
Comment thread doc/content/modules/user-manual/pages/release-notes/2026.5.0.adoc Outdated
+
image::release-notes-stakeholder-node.png[Default representation of Stakeholder connected to its corresponding `RequirementDefinition`, width=60%,height=60%]

** Add support for the frame edge.
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • frame => frame
  • edge => graphical edge

Copy link
Copy Markdown
Member Author

@gcoutable gcoutable May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread ...del-services/src/main/java/org/eclipse/syson/model/services/ModelMutationElementService.java
return newSatisfyRequirementUsage;
}

public FramedConcernMembership createFramedConcern(Type type, ConcernUsage concernUsage) {
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing javadoc

Copy link
Copy Markdown
Member Author

@gcoutable gcoutable May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gcoutable gcoutable force-pushed the gco/enh/frames-relationship branch from 0139c53 to fdf9e02 Compare May 5, 2026 15:57
@gcoutable
[2174] Add the support for frame edge
9306e7a 
Bug: #2174
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable force-pushed the gco/enh/frames-relationship branch from fdf9e02 to 9306e7a Compare May 6, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD left review comments

Assignees

No one assigned

Labels

pr: to review soon priority: high

Projects

None yet

Milestone

2026.5.0

Development

Successfully merging this pull request may close these issues.

Add the support for the frame relationship

2 participants

@gcoutable @AxelRICHARD