[releng] Switch to Sirius Web 2026.3.2#2126
Merged
AxelRICHARD merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
AxelRICHARD
force-pushed
the
ari/rel/sw202632
branch
from
90c8317 to
f68b5be
Compare
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD
force-pushed
the
ari/rel/sw202632
branch
from
f68b5be to
44ef3b9
Compare
pcdavid
approved these changes
Apr 8, 2026
Comment on lines
+84
to
+100
| @DisplayName("GIVEN the SysON REST API, WHEN we ask for projects, THEN created dates should be serialized as ISO-8601 strings") | ||
| @GivenSysONServer({ SimpleProjectElementsTestProjectData.SCRIPT_PATH }) | ||
| @Test | ||
| public void givenSysONRestAPIWhenWeAskForProjectsThenCreatedDatesShouldBeSerializedAsISO8601Strings() { | ||
| var webTestClient = WebTestClient.bindToServer() | ||
| .baseUrl(this.getHTTPBaseUrl()) | ||
| .build(); | ||
|
|
||
| var uri = String.format("/api/rest/projects"); | ||
| webTestClient.get() | ||
| .uri(uri) | ||
| .exchange() | ||
| .expectStatus() | ||
| .isOk() | ||
| .expectBody() | ||
| .jsonPath("$[0].created").isEqualTo("1970-01-01T00:00:00Z"); | ||
| } |
Contributor
There was a problem hiding this comment.
Any particular reason to have this here?
Member
Author
There was a problem hiding this comment.
Yes with the latest changes in SysMLv2SerializerConfig I was not sure about the date fields and noticed that we didn't have a test about it.
| module.addSerializer(Element.class, new SysMLv2JsonSerializer()); | ||
| this.customObjectMapper.registerModule(module); | ||
| this.customObjectMapper.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS); | ||
| this.customObjectMapper.registerModule(new JavaTimeModule()); |
Contributor
There was a problem hiding this comment.
I'm not familiar with these APIs, but just to be sure it's not been removed by mistake: we don't need new JavaTimeModule() anymore?
Member
Author
There was a problem hiding this comment.
No it seems not needed anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests