Skip to content

[2011] Improve SysML validation to be more modular#2018

Merged
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
flatombe:dev/FLA/2011
Mar 4, 2026
Merged

[2011] Improve SysML validation to be more modular#2018
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
flatombe:dev/FLA/2011

Conversation

@flatombe
Copy link
Copy Markdown
Contributor

@flatombe flatombe commented Feb 23, 2026

Notes:

  • Had to tweak JDT formatter setting "org.eclipse.jdt.core.formatter.alignment_for_enum_constants" so we get a newline for each enum literal even if it does not have Javadoc.
  • Had to tweak JDT formatter setting "org.eclipse.jdt.core.formatter.continuation_indentation_for_array_initializer" to be in-line with the formatting expected by Checkstyle.

Bug: #2011

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • [N/A] Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • [N/A] In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@flatombe flatombe force-pushed the dev/FLA/2011 branch 2 times, most recently from af5784b to 4484c70 Compare February 23, 2026 14:55
@AxelRICHARD AxelRICHARD added this to the 2026.3.0 milestone Feb 24, 2026
@AxelRICHARD AxelRICHARD linked an issue Feb 24, 2026 that may be closed by this pull request
@flatombe flatombe force-pushed the dev/FLA/2011 branch 3 times, most recently from 76aa2dc to c65c343 Compare March 3, 2026 14:46
Notes:
* Had to tweak JDT formatter setting
"org.eclipse.jdt.core.formatter.alignment_for_enum_constants" so we get
a newline for each enum literal even if it does not have Javadoc.
* Had to tweak JDT formatter setting
"org.eclipse.jdt.core.formatter.continuation_indentation_for_array_initializer"
to be in-line with the formatting expected by Checkstyle.

Bug: eclipse-syson#2011
Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
@AxelRICHARD AxelRICHARD merged commit 918d393 into eclipse-syson:main Mar 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make SysML validation more modular

3 participants