Skip to content

[1978] Add support for PortionKind edition with direct-edit in diagrams#2016

Merged
AxelRICHARD merged 1 commit intomainfrom
gco/enh/portion-kind-prefix-direct-edit
Mar 3, 2026
Merged

[1978] Add support for PortionKind edition with direct-edit in diagrams#2016
AxelRICHARD merged 1 commit intomainfrom
gco/enh/portion-kind-prefix-direct-edit

Conversation

@gcoutable
Copy link
Copy Markdown
Member

@gcoutable gcoutable commented Feb 20, 2026

Bug: #1978
Signed-off-by: Guillaume Coutable guillaume.coutable@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gcoutable gcoutable added this to the 2026.3.0 milestone Feb 20, 2026
@gcoutable gcoutable linked an issue Feb 20, 2026 that may be closed by this pull request
@gcoutable gcoutable force-pushed the gco/enh/portion-kind-prefix-direct-edit branch from 5d3aebe to 6b3fccd Compare February 20, 2026 15:49
@gcoutable gcoutable marked this pull request as ready for review February 20, 2026 15:52
Comment thread doc/content/modules/user-manual/pages/release-notes/2026.3.0.adoc Outdated
Comment thread backend/services/syson-direct-edit-grammar/src/main/resources/DirectEdit.g4 Outdated
Comment thread backend/services/syson-direct-edit-grammar/src/main/resources/DirectEdit.g4 Outdated
Comment thread backend/services/syson-direct-edit-grammar/src/main/resources/DirectEdit.g4 Outdated
@gcoutable gcoutable force-pushed the gco/enh/portion-kind-prefix-direct-edit branch from 6b3fccd to 9729c57 Compare March 2, 2026 14:53
@AxelRICHARD
Copy link
Copy Markdown
Member

@gcoutable I will fix the last remarks myself, rebase and merge the PR, thank you!

Bug: #1978
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@AxelRICHARD AxelRICHARD force-pushed the gco/enh/portion-kind-prefix-direct-edit branch from 9729c57 to 691508f Compare March 3, 2026 09:20
@AxelRICHARD AxelRICHARD merged commit 8ecf414 into main Mar 3, 2026
4 checks passed
@AxelRICHARD AxelRICHARD deleted the gco/enh/portion-kind-prefix-direct-edit branch March 3, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to direct edit the "timeslice" prefix

2 participants