Skip to content

[893] Fix Expand All tool in SysON Explorer View#1005

Merged
AxelRICHARD merged 1 commit intomainfrom
gda/fix/expandAll
Jun 25, 2025
Merged

[893] Fix Expand All tool in SysON Explorer View#1005
AxelRICHARD merged 1 commit intomainfrom
gda/fix/expandAll

Conversation

@gdaniel
Copy link
Copy Markdown
Contributor

@gdaniel gdaniel commented Feb 6, 2025

Bug: #893

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gdaniel gdaniel added this to the 2025.2.0 milestone Feb 6, 2025
@gdaniel gdaniel marked this pull request as draft February 6, 2025 17:08
@gdaniel
Copy link
Copy Markdown
Contributor Author

gdaniel commented Feb 6, 2025

This PR needs to be built against the next version of Sirius Web that integrates this PR

@AxelRICHARD AxelRICHARD linked an issue Feb 7, 2025 that may be closed by this pull request
Expand all does not work in new SysON Explorer View #893
Closed
@AxelRICHARD AxelRICHARD modified the milestones: 2025.2.0, 2025.4.0 Feb 17, 2025
@AxelRICHARD AxelRICHARD modified the milestones: 2025.4.0, 2025.6.0 Apr 11, 2025
@gdaniel gdaniel force-pushed the gda/fix/expandAll branch from e231017 to f7f7a3f Compare June 18, 2025 14:29
@gdaniel gdaniel changed the base branch from main to cooldown June 18, 2025 14:30
@gdaniel
Copy link
Copy Markdown
Contributor Author

gdaniel commented Jun 18, 2025

This PR needs to be merged in Sirius Web (and consumed in SysON) before reviewer/merging this PR:

@gdaniel gdaniel force-pushed the gda/fix/expandAll branch from f7f7a3f to f9caa3c Compare June 18, 2025 15:58
@gdaniel gdaniel changed the base branch from cooldown to main June 18, 2025 15:58
@AxelRICHARD AxelRICHARD modified the milestones: 2025.6.0, 2025.8.0 Jun 20, 2025
@gdaniel gdaniel force-pushed the gda/fix/expandAll branch from f9caa3c to 9d5ba71 Compare June 23, 2025 18:51
@gdaniel gdaniel marked this pull request as ready for review June 23, 2025 18:52
AxelRICHARD
AxelRICHARD reviewed Jun 24, 2025
View reviewed changes
Comment thread CHANGELOG.adoc Outdated

=== Breaking changes

- https://github.com/eclipse-syson/syson/issues/893[#893] [explorer] Fix _Expand All_ tool in SysON Explorer View
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explorer View => Explorer view

Copy link
Copy Markdown
Contributor Author

@gdaniel gdaniel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread CHANGELOG.adoc Outdated

=== Bug fixes

- https://github.com/eclipse-syson/syson/issues/893[#893] [explorer] Fix _Expand All_ tool in SysON Explorer View
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explorer View => Explorer view

Copy link
Copy Markdown
Contributor Author

@gdaniel gdaniel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread ...src/test/java/org/eclipse/syson/application/controller/explorer/view/SysONExplorerTests.java Outdated
Comment thread ...src/main/java/org/eclipse/syson/tree/explorer/view/SysONExplorerTreeDescriptionProvider.java Outdated
Comment thread ...src/main/java/org/eclipse/syson/tree/explorer/view/SysONExplorerTreeDescriptionProvider.java Outdated

private List<TreeItemContextMenuEntry> getContextMenuEntries() {
var expandAllMenuEntry = new TreeBuilders().newCustomTreeItemContextMenuEntry()
.contributionId("expandAll")
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"expandAll" should be extracted as a constant and reused in SysONExplorerTests#getContextMenuOfModelAndLibraryDirectories and in SysONExplorerTreeItemContextMenuEntryProvider#getTreeItemContextMenuEntries

Copy link
Copy Markdown
Contributor Author

@gdaniel gdaniel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I didn't use the constant in SysONExplorerTreeItemContextMenuEntryProvider because it corresponds to the expand all ID defined in Sirius Web, which could be different from the one in SysON. Let me know if you want me to use the same constant everywhere.

Comment thread ...rc/main/java/org/eclipse/syson/tree/explorer/view/services/ComposedSysONExplorerService.java Outdated
Comment thread ...rc/main/java/org/eclipse/syson/tree/explorer/view/services/ComposedSysONExplorerService.java Outdated
Comment thread doc/content/modules/user-manual/pages/release-notes/2025.8.0.adoc Outdated
Comment thread doc/content/modules/user-manual/pages/release-notes/2025.8.0.adoc Outdated
Comment thread ...pse/syson/tree/explorer/view/menu/context/SysONExplorerTreeItemContextMenuEntryProvider.java
@gdaniel gdaniel force-pushed the gda/fix/expandAll branch from 9d5ba71 to 797c689 Compare June 24, 2025 16:38
AxelRICHARD
AxelRICHARD reviewed Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix the last comments myself and merge the PR, thank you!

Comment thread CHANGELOG.adoc Outdated

=== Breaking changes

- https://github.com/eclipse-syson/syson/issues/893[#893] [explorer] Fix _Expand All_ tool in SysON _Explorer_ View
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View => view
(see my previous comment in the first review)

Comment thread CHANGELOG.adoc Outdated

=== Bug fixes

- https://github.com/eclipse-syson/syson/issues/893[#893] [explorer] Fix _Expand All_ tool in SysON _Explorer_ View
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View => view
(see my previous comment in the first review)

Comment thread doc/content/modules/user-manual/pages/release-notes/2025.8.0.adoc Outdated

== Breaking changes

- Fix an issue that made the _Expand All_ tool not work consistently in SysON _Explorer_ View
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View => view
(see my previous comment in the first review)

Comment thread doc/content/modules/user-manual/pages/release-notes/2025.8.0.adoc Outdated

== Bug fixes

- Fix an issue that made the _Expand All_ tool not work consistently in SysON _Explorer_ View
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View => view
(see my previous comment in the first review)

@gdaniel @AxelRICHARD
[893] Fix Expand All tool in SysON Explorer View
5688547 
Bug: #893
Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
@AxelRICHARD AxelRICHARD merged commit 60f01da into main Jun 25, 2025
4 checks passed
@AxelRICHARD AxelRICHARD deleted the gda/fix/expandAll branch June 25, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD left review comments

Assignees

No one assigned

Labels

pr: to review later priority: low

Projects

None yet

Milestone

2025.8.0

Development

Successfully merging this pull request may close these issues.

Expand all does not work in new SysON Explorer View

2 participants

@gdaniel @AxelRICHARD