Skip to content

feat(ImportCDX): remove VCS URL redirection logic #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ImportCDX): remove VCS URL redirection logic #3456

wants to merge 1 commit into from

Conversation

afsahsyeda
Copy link
Contributor

  • VCS redirection during import causes duplicate components to be created in SW360, as a new component would be created if the VCS of an existing component now points to a new location.
  • Feedback regarding the urls redirected is given after the new component has been created, leaving no room for corrections, which depletes transparency between the SBOM being imported and the components being created in SW360.
  • The SRC upload service of SW360 uploads the latest source even for old VCS URLs, removing the need to have the latest VCS URL.

@afsahsyeda afsahsyeda added the enhancement New feature or request label Oct 14, 2025
@afsahsyeda
Copy link
Contributor Author

@Suhas2109 Please perform a general test and code review of this PR.

@afsahsyeda afsahsyeda added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Oct 14, 2025
@Suhas2109
Copy link
Contributor

Suhas2109 commented Oct 15, 2025 •
edited
Loading

@afsahsyeda
Tested SBOM import with CycloneDX.
SW360 now correctly retains the original VCS URLs during import.
The PR works as expected, redirection logic is no longer applied.

@Suhas2109
Copy link
Contributor

Changes LGTM.
Test was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@GMishx GMishx Awaiting requested review from GMishx GMishx is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request needs code review needs general test This is general testing, meaning that there is no org specific issue to check for

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afsahsyeda @Suhas2109