fix(rest): Update search API to return 200 status with empty results array when no match found #2460
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afsahsyeda
added
needs code review
needs general test
|
Testing this PR. |
|
Code looks good to me. |
|
@akshitjoshii any updates with the tests on this PR? |
|
@sameed20 please rebase with latest main. |
…array when no match found Signed-off-by: sameed.ahmad <[email protected]>
sameed20
force-pushed
the
feat/return-empty-search-results-with-200-status
branch
from
ccadca8
to
fe05d9f
Compare
GMishx
approved these changes
Oct 17, 2024
GMishx
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the search API to return a 200 status code with an empty results array when no matches are found.
closes: #2459