feat(release): Enable LinkedPackagesTab in edit release and add delete package functionality #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suhas2109
force-pushed
the
fix/linkedPackagesTabAndDeleteAction
branch
from
759ff25 to
55da5c5
Compare
afsahsyeda
added
needs code review
Suhas2109
force-pushed
the
fix/linkedPackagesTabAndDeleteAction
branch
from
55da5c5 to
a972260
Compare
Contributor
|
Delete action button not working. Pls integrate the functionality. On clicking the delete button the pkg disappears from the table, it should ideally give a warning and then if the pkg is not linked to any project proceed with deletion. |
Suhas2109
force-pushed
the
fix/linkedPackagesTabAndDeleteAction
branch
from
0c7c65f to
73fb38c
Compare
Contributor
Author
|
@akshitjoshii |
Contributor
|
Pls check the build is failing. |
Contributor
|
Rebase this branch with the latest main. |
Suhas2109
force-pushed
the
fix/linkedPackagesTabAndDeleteAction
branch
2 times, most recently
from
a20e280 to
7545185
Compare
Contributor
|
@Suhas2109 It should be clear to the user like this. 
|
Suhas2109
force-pushed
the
fix/linkedPackagesTabAndDeleteAction
branch
4 times, most recently
from
77f3a68 to
cdcf4a4
Compare
Contributor
Author
Hi @akshitjoshii |
Contributor
|
@Suhas2109 , Pls take care of delete action in the Edit package page as well. Also change the delete action warning text. |
Suhas2109
force-pushed
the
fix/linkedPackagesTabAndDeleteAction
branch
2 times, most recently
from
79638ea to
0f5d2cb
Compare
…e package functionality Signed-off-by: suhas-SHS <[email protected]>
Suhas2109
force-pushed
the
fix/linkedPackagesTabAndDeleteAction
branch
from
0f5d2cb to
d379226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Release Edit Page by introducing the missing LinkedPackagesTab and enabling proper linkage and deletion of packages for a release.