Add debloat goal to determine needed and redundant classes and deps

frontend-apps/src/main/webapp/i18n/messageBundle.properties

@@ -61,12 +61,13 @@ ratioConstructApp=Application
 ratioConstructDeps=Total (app + dependencies)
 ratioConstructRatio=Percentage (app/total)
 # Metric names coming from the backend service
-class_ratio=Classes
+class_ratio=Classes, interfaces, enums
 package_ratio=Packages
 executable_ratio=Executable constructs (methods, constructors, static initializers)
 
 # Test coverage table
 packages=Application Package
+interfaces=Interfaces (traced/total)
 constructors=Constructors (traced/total)
 methods=Methods (traced/total)
 modules=Modules (traced/total)

frontend-apps/src/main/webapp/i18n/messageBundle_de.properties

@@ -48,12 +48,13 @@ ratioConstructApp=Anwendung
 ratioConstructDeps=Total (Anwendung + Abh�ngigkeiten)
 ratioConstructRatio=Prozent (Anwendung/Total)
 # Metric names coming from the backend service
-class_ratio=Klassen
+class_ratio=Klassen, Schnittstellen, Aufz�hlungstypen
 package_ratio=Pakete
 executable_ratio=Ausf�hrbare Konstrukte (Methoden, Konstruktoren, statische Initialisierer)
 
 # Test coverage table
 packages=Anwendungspaket
+interfaces=Interfaces (traced/total)
 constructors=Konstruktoren (traced/total)
 methods=Methoden (traced/total)
 static_inits=Statische Initialisierer (traced/total)

frontend-apps/src/main/webapp/i18n/messageBundle_en.properties

@@ -54,12 +54,13 @@ ratioConstructApp=Application
 ratioConstructDeps=Total (app + dependencies)
 ratioConstructRatio=Percentage (app/total)
 # Metric names coming from the backend service
-class_ratio=Classes
+class_ratio=Classes, interfaces, enums
 package_ratio=Packages
 executable_ratio=Executable constructs (methods, constructors, static initializers)
 
 # Test coverage table
 packages=Application Package
+interfaces=Interfaces (traced/total)
 constructors=Constructors (traced/total)
 methods=Methods (traced/total)
 static_inits=Static Initializers (traced/total)

frontend-apps/src/main/webapp/i18n/messageBundle_en_US.properties

@@ -54,12 +54,13 @@ ratioConstructApp=Application
 ratioConstructDeps=Total (app + dependencies)
 ratioConstructRatio=Percentage (app/total)
 # Metric names coming from the backend service
-class_ratio=Classes
+class_ratio=Classes, interfaces, enums
 package_ratio=Packages
 executable_ratio=Executable constructs (methods, constructors, static initializers)
 
 # Test coverage table
 packages=Application Package
+interfaces=Interfaces (traced/total)
 constructors=Constructors (traced/total)
 methods=Methods (traced/total)
 static_inits=Static Initializers (traced/total)

frontend-apps/src/main/webapp/view/Component.controller.js

@@ -600,6 +600,7 @@ sap.ui.controller("view.Component", {
 						singlePackage.modules=packageCounters[pack].MODU;
 						singlePackage.functions=packageCounters[pack].FUNC;
 						singlePackage.static_inits=packageCounters[pack].INIT;
+						singlePackage.interfaces=packageCounters[pack].INTF;
 
 						if(packageCountersTraced!=null&&packageCountersTraced[pack]){
 						//add if else to avoid traced CONSTRUCTORS > traced
@@ -611,6 +612,7 @@ sap.ui.controller("view.Component", {
 							singlePackage.modulesTested=packageCountersTraced[pack].MODU;
 							singlePackage.functionsTested=packageCountersTraced[pack].FUNC;
 							singlePackage.static_initsTested=packageCountersTraced[pack].INIT;
+							singlePackage.interfacesTested=packageCountersTraced[pack].INTF;
 							traced = traced + packageCountersTraced[pack].countExecutable;
 						}
 						else {
@@ -619,6 +621,7 @@ sap.ui.controller("view.Component", {
 							singlePackage.static_initsTested = 0;
 							singlePackage.modulesTested = 0;
 							singlePackage.functionsTested = 0;
+							singlePackage.interfacesTested=0;
 						}
 
 						//TODO ADD MODU & FUNCTION? (INITIATED

lang-java/pom.xml

@@ -75,6 +75,12 @@
 			<groupId>commons-io</groupId>
 			<artifactId>commons-io</artifactId>
 		</dependency>
+		<!-- Required by steady:debloat -->
+		<dependency>
+			<groupId>org.vafer</groupId>
+			<artifactId>jdependency</artifactId>
+			<version>2.7.0</version>
+		</dependency>
 
 		<!-- Test dependencies -->
 		<dependency>
@@ -105,6 +111,7 @@
 	</dependencies>
 
 	<build>
+		<testSourceDirectory>${basedir}/src/test/java</testSourceDirectory>
 		<plugins>
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>

lang-java/src/main/java/org/eclipse/steady/java/ClassFileAnalyzer.java

@@ -108,18 +108,15 @@ public Map<ConstructId, Construct> getConstructs() throws FileAnalysisException
         // TODO HP, 4.4.16: This does not yet seem to work
         ClassPoolUpdater.getInstance().updateClasspath(ctclass, this.file);
 
-        // Only add constructs of ctclass is either a class or enum (no interfaces)
-        if (ctclass.isInterface()) {
-          ClassFileAnalyzer.log.debug("Interface [" + ctclass.getName() + "] skipped");
-        } else {
-          // Use a class visitor to get all constructs from the class file
-          final ClassVisitor cv = new ClassVisitor(ctclass);
-          final Set<ConstructId> temp_constructs = cv.getConstructs();
-
-          // Add all constructs with a "" body
-          // TODO: Change Construct so that string (for source files) and binary bodies (file
-          // compiled classes) can be covered
-          for (ConstructId c : temp_constructs) this.constructs.put(c, new Construct(c, ""));
+        // Use a class visitor to get all constructs from the class file
+        final ClassVisitor cv = new ClassVisitor(ctclass);
+        final Set<ConstructId> temp_constructs = cv.getConstructs();
+
+        // Add all constructs with a "" body
+        // TODO: Change Construct so that string (for source files) and binary bodies (file
+        // compiled classes) can be covered
+        for (ConstructId c : temp_constructs) {
+          this.constructs.put(c, new Construct(c, ""));
         }
       } catch (FileNotFoundException e) {
         throw new FileAnalysisException(e.getMessage(), e);

lang-java/src/main/java/org/eclipse/steady/java/JarAnalyzer.java

@@ -526,62 +526,57 @@ else if (je.getName().endsWith("pom.xml")) {
         try {
           ctclass = JarAnalyzer.getClassPool().get(cn);
 
-          // Ignore interfaces (no executable code) and enums (rarely containing executable code,
-          // perhaps to be included later on)
-          if (ctclass.isInterface()) {
-            this.interfaceCount++;
-          } else {
-
-            if (ctclass.isEnum()) this.enumCount++;
-            else this.classCount++;
-
-            // Create ClassVisitor for the current Java class
-            cv = new ClassVisitor(ctclass);
-            this.constructs.addAll(cv.getConstructs());
-
-            // Instrument (if requested and not blacklisted)
-            if (this.instrument && !this.instrControl.isBlacklistedClass(cn)) {
-              cv.setOriginalArchiveDigest(this.getSHA1());
-              cv.setAppContext(JarAnalyzer.getAppContext());
-              if (cv.isInstrumented())
-                this.instrControl.updateInstrumentationStatistics(cv.getJavaId(), null);
-              else {
-                try {
-                  cv.visitMethods(true);
-                  cv.visitConstructors(true);
-                  cv.finalizeInstrumentation();
-                  this.instrumentedClasses.put(cv.getJavaId(), cv);
-                  this.instrControl.updateInstrumentationStatistics(
-                      cv.getJavaId(), Boolean.valueOf(true));
-                } catch (IOException ioe) {
-                  JarAnalyzer.log.error(
-                      "I/O exception while instrumenting class ["
-                          + cv.getJavaId().getQualifiedName()
-                          + "]: "
-                          + ioe.getMessage());
-                  this.instrControl.updateInstrumentationStatistics(
-                      cv.getJavaId(), Boolean.valueOf(false));
-                } catch (CannotCompileException cce) {
-                  JarAnalyzer.log.warn(
-                      "Cannot compile instrumented class ["
-                          + cv.getJavaId().getQualifiedName()
-                          + "]: "
-                          + cce.getMessage());
-                  this.instrControl.updateInstrumentationStatistics(
-                      cv.getJavaId(), Boolean.valueOf(false));
-                } catch (Exception e) {
-                  JarAnalyzer.log.error(
-                      e.getClass().getName()
-                          + " occured while instrumenting class ["
-                          + cv.getJavaId().getQualifiedName()
-                          + "]: "
-                          + e.getMessage());
-                  this.instrControl.updateInstrumentationStatistics(
-                      cv.getJavaId(), Boolean.valueOf(false));
-                }
+          if (ctclass.isEnum()) this.enumCount++;
+          else if (ctclass.isInterface()) this.interfaceCount++;
+          else this.classCount++;
+
+          // Create ClassVisitor for the current Java class
+          cv = new ClassVisitor(ctclass);
+          this.constructs.addAll(cv.getConstructs());
+
+          // Instrument (if requested and not blacklisted)
+          if (this.instrument && !this.instrControl.isBlacklistedClass(cn)) {
+            cv.setOriginalArchiveDigest(this.getSHA1());
+            cv.setAppContext(JarAnalyzer.getAppContext());
+            if (cv.isInstrumented())
+              this.instrControl.updateInstrumentationStatistics(cv.getJavaId(), null);
+            else {
+              try {
+                cv.visitMethods(true);
+                cv.visitConstructors(true);
+                cv.finalizeInstrumentation();
+                this.instrumentedClasses.put(cv.getJavaId(), cv);
+                this.instrControl.updateInstrumentationStatistics(
+                    cv.getJavaId(), Boolean.valueOf(true));
+              } catch (IOException ioe) {
+                JarAnalyzer.log.error(
+                    "I/O exception while instrumenting class ["
+                        + cv.getJavaId().getQualifiedName()
+                        + "]: "
+                        + ioe.getMessage());
+                this.instrControl.updateInstrumentationStatistics(
+                    cv.getJavaId(), Boolean.valueOf(false));
+              } catch (CannotCompileException cce) {
+                JarAnalyzer.log.warn(
+                    "Cannot compile instrumented class ["
+                        + cv.getJavaId().getQualifiedName()
+                        + "]: "
+                        + cce.getMessage());
+                this.instrControl.updateInstrumentationStatistics(
+                    cv.getJavaId(), Boolean.valueOf(false));
+              } catch (Exception e) {
+                JarAnalyzer.log.error(
+                    e.getClass().getName()
+                        + " occured while instrumenting class ["
+                        + cv.getJavaId().getQualifiedName()
+                        + "]: "
+                        + e.getMessage());
+                this.instrControl.updateInstrumentationStatistics(
+                    cv.getJavaId(), Boolean.valueOf(false));
               }
             }
           }
+
           if (!this.instrument) {
             // only detach if no static instrumentation (otherwise it will fail
             // because the class was modified) in case the instrumentation is
@@ -627,7 +622,7 @@ else if (je.getName().endsWith("pom.xml")) {
                 + constructs.size()
                 + "], enums ["
                 + enumCount
-                + "], interfaces (ignored) ["
+                + "], interfaces ["
                 + interfaceCount
                 + "]");
       else
@@ -639,7 +634,7 @@ else if (je.getName().endsWith("pom.xml")) {
                 + this.classCount
                 + "], enums ["
                 + enumCount
-                + "], interfaces (ignored) ["
+                + "], interfaces ["
                 + interfaceCount
                 + "]");
     }

lang-java/src/main/java/org/eclipse/steady/java/JavaFileAnalyzer2.java

@@ -181,7 +181,7 @@ public void exitEnumDeclaration(@NotNull JavaParser.EnumDeclarationContext ctx)
   /**
    * {@inheritDoc}
    *
-   * Interfaces are not added to {@link #constructs}.
+   * Interfaces are added to {@link #constructs}.
    */
   @Override
   public void enterInterfaceDeclaration(@NotNull JavaParser.InterfaceDeclarationContext ctx) {
@@ -191,6 +191,7 @@ public void enterInterfaceDeclaration(@NotNull JavaParser.InterfaceDeclarationCo
         (cse == null ? JavaPackageId.DEFAULT_PACKAGE : (JavaId) cse.getConstructId());
     final JavaId id = new JavaInterfaceId(decl_ctx, ctx.IDENTIFIER().getText());
     this.contextStack.push(id);
+    this.saveConstruct(id, this.getConstructContent(ctx));
   }
 
   /** {@inheritDoc} */
@@ -231,6 +232,24 @@ public void enterClassBody(@NotNull JavaParser.ClassBodyContext ctx) {
     this.constructIdBuilder.resetCurrentDeclarationContext();
   }
 
+  @Override
+  public void enterInterfaceMemberDeclaration(JavaParser.InterfaceMemberDeclarationContext ctx) {
+    if (ctx.interfaceMethodDeclaration() != null) {
+      // Peek JavaId and ensure it is an interface
+      final JavaId class_ctx = (JavaId) this.contextStack.peek().getConstructId();
+      this.isOfExpectedType(class_ctx, new JavaId.Type[] {JavaId.Type.INTERFACE}, true);
+
+      // Build the identifier
+      final JavaMethodId id =
+          new JavaMethodId(
+              (JavaId) class_ctx,
+              ctx.interfaceMethodDeclaration().IDENTIFIER().getText(),
+              this.getParameters(
+                  ctx.interfaceMethodDeclaration().formalParameters().formalParameterList()));
+      this.saveConstruct(id, this.getConstructContent(ctx));
+    }
+  }
+
   /** {@inheritDoc} */
   @Override
   public void exitClassBody(@NotNull JavaParser.ClassBodyContext ctx) {
@@ -244,7 +263,10 @@ public void exitClassBody(@NotNull JavaParser.ClassBodyContext ctx) {
   public void enterMethodDeclaration(@NotNull JavaParser.MethodDeclarationContext ctx) {
     // Peek JavaId and ensure it is a class or enum
     final JavaId class_ctx = (JavaId) this.contextStack.peek().getConstructId();
-    this.isOfExpectedType(class_ctx, new JavaId.Type[] {JavaId.Type.CLASS, JavaId.Type.ENUM}, true);
+    this.isOfExpectedType(
+        class_ctx,
+        new JavaId.Type[] {JavaId.Type.CLASS, JavaId.Type.ENUM, JavaId.Type.INTERFACE},
+        true);
 
     // Build the identifier
     final JavaMethodId id =