JsWidgets: add simple tab box #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschinkel
force-pushed
the
features/ttr/25.2/simple-tab-box-with-vertical-tabs
branch
from
0b95829 to
b79db23
Compare
fschinkel
requested changes
Nov 10, 2025
| } | ||
| ] | ||
| }, | ||
| { |
Member
There was a problem hiding this comment.
The pages are ordered alphabetically and Simple... comes after Sequence....
| closableField: CheckBoxField; | ||
| statusField: SmartField<StatusSeverity>; | ||
|
|
||
| protected _tabCounter: number; |
Member
There was a problem hiding this comment.
There is no need to separate the declaration and the initialization. As there is no difference in e.g. the simpleTabBox being undefined or null, the majority of the constructor can be removed.
The _tabCounter initialization can be replaced by
Suggested change
| protected _tabCounter: number; | |
| protected _tabCounter = 0; |
| } | ||
|
|
||
| abort() { | ||
| MessageBoxes.createOk(this) |
Member
There was a problem hiding this comment.
Why do you not remove the view?
| import {ConfigurationBox, EventsTab, EventsTabWidgetMap, IconIdLookupCall, StatusSeverityLookupCall, WidgetActionsBox, WidgetActionsBoxWidgetMap} from '../index'; | ||
|
|
||
| export default (): FormModel => ({ | ||
| id: 'jswidgets.SimpleTabBoxForm', |
|
|
||
| export default (): FormModel => ({ | ||
| id: 'jswidgets.SimpleTabBoxForm', | ||
| displayHint: 'view', |
|
|
||
| this.statusField = this.widget('StatusField'); | ||
| this.statusField.on('propertyChange:value', this._onStatusFieldValueChange.bind(this)); | ||
| } |
Member
There was a problem hiding this comment.
Initialize action and event tab
this.widget('WidgetActionsBox').setField(this.simpleTabBox);
this.widget('EventsTab').setField(this.simpleTabBox);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.