-
Notifications
You must be signed in to change notification settings - Fork 26
import: import log crate as baseline #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
import: import log crate as baseline #18
Conversation
9fb527d
to
ae050e3
Compare
@hoppe-and-dreams @rmaddikery @arsibo The frontend was moved as requested. (FYI: @darkwisebear ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please first request the upstream to change if that doesn't work we should to a real fork in a separate repository.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the repo does not have all the checks in place please add in description if you follow Rust's naming convention and coding guidelines? E.g.: https://github.com/rust-lang/style-team/blob/master/guide/guide.md
I see few unit tests, but not covered for all. Is this planned?
https://doc.rust-lang.org/rust-by-example/testing.html
Follow ups plannned after this PR: For "imported" code, this is as is. As in above, this going to be fixed in MVP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A readme can be useful that demonstrates the usage and assumptions of use
As this is enabler from open source, no UT planned for this code. Only for new MVP providing proper frontend. |
name = "mw_log" | ||
version = "0.0.1" | ||
authors = ["S-CORE"] | ||
readme = "README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IS this missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Quality and naming output: pawel@pawel-VirtualBox ~/qorix/repos/baselibs/score/mw/log/rust (pawelrutkaq_rust_log_frontend) $ cargo build So common pratices for Rust followed. |
302b587
to
ff6f931
Compare
Import from log crate 3aa1359e926a39f841791207d6e57e00da3e68e2 at https://github.com/rust-lang/log Signed-off-by: Pawel Rutka <[email protected]>
ff6f931
to
e173ade
Compare
Import from log crate 3aa1359e926a39f841791207d6e57e00da3e68e2 at https://github.com/rust-lang/log
This is as follow up to decision in CFG Logging: eclipse-score/inc_mw_log#6 (comment)
to enable Rust code with common frontend.
Please consider that this is only enabler (eclipse-score/inc_mw_log#5), and frontend will be done from scratch in S-CORE (however it will be macro compatible). The Rust binding to
C++ mw::log
will be located in newlogging
repo.