Skip to content

Conversation

pawelrutkaq
Copy link

@pawelrutkaq pawelrutkaq commented Sep 16, 2025

Import from log crate 3aa1359e926a39f841791207d6e57e00da3e68e2 at https://github.com/rust-lang/log

This is as follow up to decision in CFG Logging: eclipse-score/inc_mw_log#6 (comment)
to enable Rust code with common frontend.

Please consider that this is only enabler (eclipse-score/inc_mw_log#5), and frontend will be done from scratch in S-CORE (however it will be macro compatible). The Rust binding to C++ mw::log will be located in new logging repo.

@pawelrutkaq
Copy link
Author

@hoppe-and-dreams @rmaddikery @arsibo The frontend was moved as requested. (FYI: @darkwisebear )

Copy link

@FScholPer FScholPer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please first request the upstream to change if that doesn't work we should to a real fork in a separate repository.

@pawelrutkaq
Copy link
Author

Can you please first request the upstream to change if that doesn't work we should to a real fork in a separate repository.
Not sure what does not work ?:)

Copy link

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the repo does not have all the checks in place please add in description if you follow Rust's naming convention and coding guidelines? E.g.: https://github.com/rust-lang/style-team/blob/master/guide/guide.md

I see few unit tests, but not covered for all. Is this planned?
https://doc.rust-lang.org/rust-by-example/testing.html

@pawelrutkaq
Copy link
Author

Follow ups plannned after this PR:
eclipse-score/score#1896
eclipse-score/score#1897

For "imported" code, this is as is. As in above, this going to be fixed in MVP

Copy link

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A readme can be useful that demonstrates the usage and assumptions of use

@pawelrutkaq
Copy link
Author

Since the repo does not have all the checks in place please add in description if you follow Rust's naming convention and coding guidelines? E.g.: https://github.com/rust-lang/style-team/blob/master/guide/guide.md

I see few unit tests, but not covered for all. Is this planned? https://doc.rust-lang.org/rust-by-example/testing.html

As this is enabler from open source, no UT planned for this code. Only for new MVP providing proper frontend.

name = "mw_log"
version = "0.0.1"
authors = ["S-CORE"]
readme = "README.md"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS this missing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pawelrutkaq
Copy link
Author

Since the repo does not have all the checks in place please add in description if you follow Rust's naming convention and coding guidelines? E.g.: https://github.com/rust-lang/style-team/blob/master/guide/guide.md

I see few unit tests, but not covered for all. Is this planned? https://doc.rust-lang.org/rust-by-example/testing.html

Quality and naming output:
pawel@pawel-VirtualBox ~/qorix/repos/baselibs/score/mw/log/rust (pawelrutkaq_rust_log_frontend) $ cargo clippy
Checking mw_log v0.0.1 (/home/pawel/qorix/repos/baselibs/score/mw/log/rust)
Finished dev profile [unoptimized + debuginfo] target(s) in 0.15s

pawel@pawel-VirtualBox ~/qorix/repos/baselibs/score/mw/log/rust (pawelrutkaq_rust_log_frontend) $ cargo build
Compiling mw_log v0.0.1 (/home/pawel/qorix/repos/baselibs/score/mw/log/rust)
Finished dev profile [unoptimized + debuginfo] target(s) in 0.11s

So common pratices for Rust followed.

@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_rust_log_frontend branch 2 times, most recently from 302b587 to ff6f931 Compare October 15, 2025 07:41
Import from log crate 3aa1359e926a39f841791207d6e57e00da3e68e2
at https://github.com/rust-lang/log

Signed-off-by: Pawel Rutka <[email protected]>
@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_rust_log_frontend branch from ff6f931 to e173ade Compare October 15, 2025 07:43
@pawelrutkaq pawelrutkaq requested a review from FScholPer October 16, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants