Mark removal for unused deprecated methods and constants #3427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepika-u
force-pushed
the
deprecated_methods1
branch
from
e5fd659 to
e905926
Compare
deepika-u
force-pushed
the
deprecated_methods1
branch
6 times, most recently
from
7d41213 to
033d7e1
Compare
internal deprecated methods being removed.
deepika-u
force-pushed
the
deprecated_methods1
branch
from
033d7e1 to
45fd2c9
Compare
|
@akurtakov |
|
LGTM |
oh wow! thanks alot. If no more changes suggested can you take it forward please? |
|
Planning to merge this tomorrow, if no one objects. @deepika-u thanks, sorry for the long delay in review times. |
np, you may please proceed. |
|
Based on the info from @merks merging now so that we have this in m2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change marks several deprecated, unused methods for removal and internal deprecated methods being removed.