Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Oct 17, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Test Results

 3 018 files   3 018 suites   2h 20m 50s ⏱️
 8 229 tests  7 980 ✅ 249 💤 0 ❌
23 607 runs  22 813 ✅ 794 💤 0 ❌

Results for commit fd4a5b8.

♻️ This comment has been updated with latest results.

Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM but I see this error in the logs:

 Error: Please always use rebase to update your branch

Infrastructure problem?

Also, the GH bot says this PR removes tests. I hope the information is outdated. One can only double-check that when the tests finish running.

@vogella vogella force-pushed the jface.text.tests_3 branch from 64ebd0e to 7ced97e Compare October 20, 2025 09:47
@vogella
Copy link
Contributor Author

vogella commented Oct 20, 2025

@fedejeanne I pushed a new change set with the changes, lets see if that fix the "removed lots of tests" message.

@fedejeanne
Copy link
Member

Hm, the message is still there, but I think I know why (at least in part): some tests require org.junit.jupiter.api.function to work, like you did in #3410 (details in #3410 (comment))

@vogella vogella force-pushed the jface.text.tests_3 branch 2 times, most recently from e952cf2 to 8c5a776 Compare October 21, 2025 15:48
@vogella
Copy link
Contributor Author

vogella commented Oct 21, 2025

@fedejeanne should be fine now, I plan to merge this in the next days until I hear more feedback.

@vogella vogella force-pushed the jface.text.tests_3 branch from 8c5a776 to fd4a5b8 Compare October 22, 2025 05:14
@akurtakov akurtakov merged commit da8753c into eclipse-platform:master Oct 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants