-
Notifications
You must be signed in to change notification settings - Fork 226
Option in chevron dropdown to display the most recently active editors at the top of the list #3256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Could you provide some reproducible steps to understand how the current behavior is changed / verify the new behavior? |
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Test Results 603 files - 2 415 603 suites - 2 415 1m 29s ⏱️ - 2h 44m 24s Results for commit 9670aa7. ± Comparison against base commit 1848058. This pull request removes 6898 tests.♻️ This comment has been updated with latest results. |
I am working on a corner case with the current PR. It’s still a work in progress, and I’ll share a screenshot or video once it’s completed. |
bb9ce7d to
661a6d1
Compare
f4fa542 to
d25ab66
Compare
|
A very useful feature @elsazac, Thanks for working on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks useful but there a two things that should be adjusted:
- the icon does not seen suitable, also from the name it seem to be a different purpose can we use something else?
- Why do we need to play around with the actual input? That do not seems appropriate here a ViewerFiler/Sorter should be sufficient to to what ever is needed and would not require to modify/depend on
BasicPartList
|
That's indeed a nice feature. I have to following comments
|
d25ab66 to
60801a5
Compare
Yes it is doable. |
Each tab inserted into a CTabFolder is assigned an index, and all these indexes are stored. A priority list with the indexes are maintained that changes dynamically depending on the user activity. Apart from this, the chevron pop list is sorted using a comparator in ascending order. |
When there are many editors in the workbench, editors may overflow into the chevron pop at the same time; so it will be difficult to track the editors that most recently got hidden inside the chevron; so in a way i am trying to display the list of items in the chevron pop in the order in which they were most recently added into the pop up; the most recently added item goes to the top and so on; Sorry that i forgot to mention about this in the PR description. My use case is to display only the elements that went inside the chevron pop up; Those that are already visible/shown in the workbench need not be shown in the chevron pop up using the toggle button (By default the chevron pop up contains all the editors opened in the workbench). The purpose of this toggle button is to show only the elements that overflowed to the chevron and that too in the order of most recently added elements to chevron pop. Thats why the list is short after the button is clicked. The default behaviour of the list can be seen on clicking the toggle again |
|
additonaly I have also just pushed an update to resize the table's height according to the new input size only for toggle button. |
60801a5 to
9105646
Compare
I wasn’t able to find anything similar to this. The input provided to the comparator also comes from getTableViewer. I couldn't understand completely. Could you please help clarify ? |
20ea3fa to
4d32093
Compare
|
Are there any outstanding concerns on this PR? |
4d32093 to
27730bd
Compare
|
@laeubi Could you check and let me know if there are any outstanding concerns on this PR; |
|
I have the feeling that we need to have a look at this from UX perspective before this can be merged. This should not be rushed in. |
27730bd to
8aac183
Compare
editors In the workbench, the chevron drop down shows all editors, including those that cannot fit in the main editor area. By default, these editors are ordered using a comparator, which makes it harder to quickly navigate to editors that recently moved into the chevron due to overflow. This change introduces a toggle button near the filter text in the chevron drop down that allows users to switch the order to a new one. This new view displays the editors that most recently moved into the chevron drop down at the top. Activating the toggle displays these recently overflowed editors first, providing quick access, while clicking it again restores the normal display order. This feature improves visibility when there are so many editors that are open in the workbench window and editors overflow into the chevron at the same time.
8aac183 to
9670aa7
Compare
Add a toggle button near the filter text area in the chevron drop down to show the most recently overflowed editors at the top for easy access.
In the workbench, the chevron dropdown shows all editors along with the one’s that cannot fit in the main editor area.By default, these editors have an order sorted out using a comparator ie ascending order. But with so many editors open in the workbench, it is harder to quickly navigate and locate the editors that recently moved into the chevron due to overflow.
This change introduces a toggle button in the chevron dropdown that allows users to switch the view so that editors that most recently moved into the chevron appear at the top. When the toggle is activated, these recently overflowed editors are displayed first, making it easier for users to quickly access them. Clicking the toggle again restores the normal display order of the chevron, providing a simple way to alternate between the default and recently overflowed editor order.
The toggle button click will display only the elements that went inside to the chevron pop up; Those that are already visible/shown in the workbench are not shown in the chevron pop up using the toggle button .The purpose of this toggle button is to show only the elements that overflowed to the chevron and that too in the order of most recently added elements to chevron pop.
This is especially useful when many editors are open in the workbench and editors overflow into the chevron.
The change introduces :
most recent editor firstorder.The toggle button is shown below :
Video :
Imp_Feature.mov