Skip to content

Conversation

arunjose696
Copy link
Contributor

This PR does not cause a visual impact but is meant for completeness to replace Image(Device, ImageData) with Image(Device, ImageDataProvider), making sure the earlier behaviour is preserved.

Steps to reproduce

The radial gradients are in the CSS selector.

  1. Open CSS Spy
  2. For the background color field, enter a list that is a radial gradient. I entered the below list:
gradient radial white black gainsboro lightgray silver gray dimgray darkslategray black midnightblue navy darkblue mediumblue blue dodgerblue deepskyblue lightseagreen mediumseagreen seagreen forestgreen green darkgreen

Screenshot

Provider_225

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From cf3ee664ffebe636cf2f0bedd5f403a7998e8c64 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 13 Jun 2025 09:00:44 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
index 9e193a6310..d704b7f44e 100644
--- a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.css.swt;singleton:=true
-Bundle-Version: 0.15.600.qualifier
+Bundle-Version: 0.15.700.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Jun 13, 2025

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 24m 51s ⏱️ - 2h 51m 35s
 8 226 tests ±0   7 976 ✅ ±0  249 💤 ±0  1 ❌ ±0 
23 598 runs  ±0  22 803 ✅ ±0  794 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 19b65c4. ± Comparison against base commit 80643f0.

♻️ This comment has been updated with latest results.

@amartya4256
Copy link
Contributor

The CI builds seem to be failing because of the version inconsistency. Can you have a look at the logs?

@arunjose696 arunjose696 force-pushed the bug/arun/199/radialGradient_IG branch from 81dc48a to cfd0e25 Compare October 8, 2025 11:16
@arunjose696
Copy link
Contributor Author

The CI failures are because of the introduction of junit 6 in platform.ui.
eclipse-platform/eclipse.platform.releng.aggregator#3399. The failures are unrelated to the change.

@fedejeanne
Copy link
Member

Once the CI is stable again, we can merge this. Ping me @arunjose696

This PR does not cause a visual impact but is meant for completeness to
Replace Image(Device, ImageData) with Imagde(Device, ImageDataProvider)
making sure the earlier behaviour is preserved
@fedejeanne fedejeanne force-pushed the bug/arun/199/radialGradient_IG branch from cfd0e25 to 19b65c4 Compare October 10, 2025 11:10
@fedejeanne
Copy link
Member

Test failure is unrelated: #294

@fedejeanne fedejeanne merged commit 080a1c7 into eclipse-platform:master Oct 13, 2025
16 of 18 checks passed
@fedejeanne fedejeanne deleted the bug/arun/199/radialGradient_IG branch October 13, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate calling places of Image constructors with ImageData Use constructor Image(Device, ImageDataProvider) for Radial gradients

4 participants