-
Notifications
You must be signed in to change notification settings - Fork 226
Use constructor Image(Device, ImageDataProvider) for Radial gradients #3040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use constructor Image(Device, ImageDataProvider) for Radial gradients #3040
Conversation
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
Test Results 3 018 files ±0 3 018 suites ±0 2h 24m 51s ⏱️ - 2h 51m 35s For more details on these failures, see this check. Results for commit 19b65c4. ± Comparison against base commit 80643f0. ♻️ This comment has been updated with latest results. |
...lipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/GradientBackgroundListener.java
Outdated
Show resolved
Hide resolved
The CI builds seem to be failing because of the version inconsistency. Can you have a look at the logs? |
81dc48a
to
cfd0e25
Compare
The CI failures are because of the introduction of junit 6 in platform.ui. |
Once the CI is stable again, we can merge this. Ping me @arunjose696 |
This PR does not cause a visual impact but is meant for completeness to Replace Image(Device, ImageData) with Imagde(Device, ImageDataProvider) making sure the earlier behaviour is preserved
cfd0e25
to
19b65c4
Compare
Test failure is unrelated: #294 |
This PR does not cause a visual impact but is meant for completeness to replace
Image(Device, ImageData)
withImage(Device, ImageDataProvider)
, making sure the earlier behaviour is preserved.Steps to reproduce
The radial gradients are in the CSS selector.
Screenshot