Lazy load disabled icons in AbstractContributionItem #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractionContributionItems load their disabled icons even if the icon's widget is not disabled. This unnecessarily occupies resources that may never be used. This change updates the implementation to lazily load or create the disabled icon once the element is actually disabled for the first time.
Test Results 1 824 files 1 824 suites 1h 39m 53s ⏱️ Results for commit 3c1e07b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractionContributionItems load their disabled icons even if the icon's widget is not disabled. This unnecessarily occupies resources that may never be used.
This change updates the implementation to lazily load or create the disabled icon once the element is actually disabled for the first time.
This is a follow-up on:
I propose to postpone this to M1 as it's only a slight improvement of long-standing behavior, so no need to risk any regression.