Newer Workspace Version popup dialog ui alignment changes. #2949
Conversation
|
I don't think that center-aligning the button brings an advantage. |
Thanks for your opinion, will be reverting the 2nd change. Updated as per review comments. |
deepika-u
force-pushed
the
newWorkspace_opened_with_oldEclipse
branch
2 times, most recently
from
91596bb to
b45c15e
Compare
Now after the fix, only the check box line is aligned and the buttons will continue to right align as earlier. Now after this fix only the 2nd line is aligned changing the behavior of the current popup dialog leaving the original dialog alignments as-is. |
|
@BeckerWdf : can you check this when you have some time please? |
per review comments.
deepika-u
force-pushed
the
newWorkspace_opened_with_oldEclipse
branch
from
b45c15e to
399983b
Compare
|
@tomaswolf @BeckerWdf Here as per the suggestions buttons are right aligned. |
|
Aligning the text and the checkbox is fine for me. I know this dialog a lot. I never felt it was wrong. But I think having the checkbox left aligned (with the icon) indeed is not correct. |
| @@ -727,6 +729,17 @@ protected ReturnCode checkValidWorkspace(Shell shell, URL url) { | |||
| MessageDialogWithToggle dialog = new MessageDialogWithToggle(shell, title, null, message, severity, | |||
| buttonLabelToId, 0, IDEWorkbenchMessages.IDEApplication_version_doNotWarnAgain, false) { | |||
| @Override | |||
| protected Control createDialogArea(Composite parent) { | |||
There was a problem hiding this comment.
is this the right place to fix this. Shouldn't we fix this in MessageDialogWithToggle?
So that for all the dialogs inheriting from this class the checkbox is aligned with the text and not with the icon?
There was a problem hiding this comment.
is this the right place to fix this. Shouldn't we fix this in MessageDialogWithToggle?
Checking on this, will update you soon.
There was a problem hiding this comment.
Hi @BeckerWdf
I tried updating the method createToggleButton() as below in MessageDialogWithToggle.java(leaving createDialogArea() untouched) but it is not being honoured to correct the indentation of check box as required.
GridData data = new GridData(SWT.BEGINNING, SWT.TOP, false, false);
data.horizontalIndent = 50;
Do you have any other thoughts?
There was a problem hiding this comment.
@BeckerWdf : Can we merge this fix like this? if you dont have any further suggestions.
Before the fix the dialog used to show up as
After the fix the dialog now is showed up as
This popup dialog basically comes when a workspace for example already used/edited/saved in 4.36 and now attempted to open with an older eclipse say 4.35 or lower, this pop up shows up.
Change 1 : check box is aligned.
Change 2 : Button bar is center aligned.
Here we are changing the behavior of the current popup dialog leaving the original dialog alignments as-is.