Cache the last created temporary handles at a requested size #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache the most recently created temporary handle. When a handle of a different size is requested, dispose of the previous one and replace it with the new handle. The last cached handle is also destroyed when the image is disposed.
arunjose696
force-pushed
the
arunjose696/469/cacheHandles
branch
from
d897312 to
ac8d6ec
Compare
fedejeanne
requested changes
Oct 10, 2025
| imageHandle.destroy(); | ||
| } | ||
| } | ||
| lastRequestedHandle.destroy(); |
There was a problem hiding this comment.
This doesn't belong here, the method accepts a filter. Put it in destroyHandles() and, if necessary, in destroyHandlesExcept(Set<Integer>) too.
| } | ||
| }; | ||
|
|
||
| CachedHandle lastRequestedHandle = new CachedHandle(null, SWT.DEFAULT, SWT.DEFAULT, SWT.DEFAULT, SWT.DEFAULT); |
There was a problem hiding this comment.
Move it above the type-declaration (together with other fields), make it private and pass -1 instead of SWT.DEFAULT as parameters. There is no "default" in this context, only "uninitialized".
| imageData.height); | ||
| } | ||
| handleAtSizeConsumer.accept(lastRequestedHandle.getHandle(), | ||
| new Point(lastRequestedHandle.handleWidth, lastRequestedHandle.handleHeight)); |
There was a problem hiding this comment.
Suggested change
| new Point(lastRequestedHandle.handleWidth, lastRequestedHandle.handleHeight)); | |
| new Point(lastRequestedHandle.handleWidth(), lastRequestedHandle.handleHeight())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering images at a specific targetSize, the most recently created temporary handle is cached. If a handle of a different size is needed, the previous handle is disposed of and replaced with the new one. The last cached handle is also disposed of when the image itself is destroyed.
This change does not affect the visual appearance and is purely an optimization. It is especially useful when a user scrolls through a diagram, as the same-size image may be redrawn multiple times. Without handle caching, new image handles would need to be created repeatedly whenever the image is redrawn. More details can be found at vi-eclipse/Eclipse-Platform#326 (comment)