Skip to content

Fixing transparency on scaled variant of cursor with source and mask #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

Fixing transparency on scaled variant of cursor with source and mask #2562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Cursor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,12 +684,16 @@ private void validateMask(ImageData source, ImageData mask) {

@Override
public CursorHandle createHandle(Device device, int zoom) {
float accessibilityFactor = getPointerSizeScaleFactor();
int scaledZoom = (int) (zoom * accessibilityFactor);
ImageData scaledSource = DPIUtil.scaleImageData(device, this.source, scaledZoom, DEFAULT_ZOOM);
ImageData scaledMask = this.mask != null ? DPIUtil.scaleImageData(device, mask, scaledZoom, DEFAULT_ZOOM)
: null;

float scaledZoomFactor = zoom * getPointerSizeScaleFactor() / 100f;
int scaledSourceWidth = Math.round(this.source.width * scaledZoomFactor);
int scaledSourceHeight = Math.round(this.source.height * scaledZoomFactor);
ImageData scaledSource = this.source.scaledTo(scaledSourceWidth, scaledSourceHeight);
ImageData scaledMask = null;
if (this.mask != null) {
int scaledMaskWidth = Math.round(this.mask.width * scaledZoomFactor);
int scaledMaskHeight = Math.round(this.mask.height * scaledZoomFactor);
scaledMask = this.mask.scaledTo(scaledMaskWidth, scaledMaskHeight);
}
return setupCursorFromImageData(device, scaledSource, scaledMask, getHotpotXInPixels(zoom),
getHotpotYInPixels(zoom));
}
Expand Down
Loading