[win32] Calculate value for NATIVE_ZOOM on demand #2519
Conversation
akoch-yatta
force-pushed
the
win32-remove-nativezoom-from-data
branch
from
07fe3d9 to
4b8c0fd
Compare
|
|
||
| @Override | ||
| public Object getData(String key) { | ||
| if (DATA_NATIVE_ZOOM.equals(key)) { |
There was a problem hiding this comment.
why do we need DATA_NATIVE_ZOOM at all?
Cant all places that currently use that key simply perform the code itself?
There was a problem hiding this comment.
Currently it is some kind of a hidden feature, that should be replaced in the long run by an API solution. We want to evolve the usage of this data point (e.g. in GEF as an example) with this before we introduce a unnecessary or not suitable API. But until there is a proper usable solution, we would like to at least reduce the memory footprint of that.
There was a problem hiding this comment.
Can you explain how/where it is used and why a "hidden key" is better than a (preliminary) API? One would suspect both to be internal and subject to change so the benefit is a bit unclear. Especially as it seems only ever a property of the shell itself.
There was a problem hiding this comment.
In general this data is currently needed for an experimental feature for GEF to disable the SWT autoscaling for the diagram canvas and incorporate all scaling to GEF. There we still need the information about the zoom, that would have been applied by SWT if it was not disabled.
So, I did some discussion with @HeikoKlare and we discussed assuming the solution (which is currently there for windows) can be applied in the same way to GTK and cocoa. But we are unsure about this, so we would like to prevent adding perhaps unnecessary API. The adaption to GTK and cocoa will most likely not happen in this release cycle.
Test Results 118 files 118 suites 10m 48s ⏱️ Results for commit 29f0f3c. ♻️ This comment has been updated with latest results. |
akoch-yatta
force-pushed
the
win32-remove-nativezoom-from-data
branch
2 times, most recently
from
735458c to
f739d6a
Compare
To remove the memory footprint of Widget this commit removes the value for NATIVE_ZOOM from the data attribute and replaces it by calculating the value in Control#getData on demand. Additionally the naming is changed to SHELL_ZOOM.
akoch-yatta
force-pushed
the
win32-remove-nativezoom-from-data
branch
from
f739d6a to
29f0f3c
Compare
To remove the memory footprint of Widget this PR removes the value for NATIVE_ZOOM from the data attribute and replaces it by calculating the value in Control#getData on demand.
This does not change the value that is returned by NATIVE_ZOOM.