Add internal API in SVGrasterizer to rasterize images at given height and width #2514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arunjose696 can we please mirror the (relevant) information in the PR? Its always a bit hard to follow for others what are is discussed if it happens in another repository with a different organization. |
laeubi
reviewed
Sep 15, 2025
| @@ -32,4 +32,6 @@ public interface SVGRasterizer { | |||
| * the input is not a valid SVG file or cannot be processed. | |||
| */ | |||
| public ImageData rasterizeSVG(InputStream stream, int zoom) throws IOException; | |||
|
|
|||
| public ImageData rasterizeSVG(InputStream stream, int width, int height) throws IOException; | |||
There was a problem hiding this comment.
Please add javadoc here, also if there are any limitations (e.g. what happens when size is negative).
… and width Adding internal API to SVGRasterizer and simple tests to see if the svgs are loaded at right sizes by the rasterizer
arunjose696
force-pushed
the
arunjose696/326/rasterizer
branch
from
663817f to
c04bcdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shall be possible to draw images at a custom zoom or size while maintaining the best achievable quality. To support this, images originating from an SVG source must be rasterized at the required size.
The internal API introduced in this PR enables loading SVGs at custom sizes, allowing images to be drawn at any requested zoom level or resolution, as discussed in in vi-eclipse/Eclipse-Platform#326
This PR specifically adds the internal API to handle rasterization for images coming from SVG sources.