Skip to content

[win32] Use consistent font zoom retrieval #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akoch-yatta
Copy link
Contributor

@akoch-yatta akoch-yatta commented Apr 2, 2025

This PR unifies the extraction of the target zoom of a font to be
affected by the zoom context of the underlying Widget. Before there
were different strategies like getting it from the Shell.

Copy link
Contributor

github-actions bot commented Apr 2, 2025

Test Results

   545 files  + 6     545 suites  +6   24m 48s ⏱️ - 7m 8s
 4 367 tests +37   4 355 ✅ +35   12 💤 +3  0 ❌  - 1 
16 616 runs  +37  16 512 ✅ +35  104 💤 +3  0 ❌  - 1 

Results for commit be9b308. ± Comparison against base commit 3670670.

♻️ This comment has been updated with latest results.

@akoch-yatta akoch-yatta marked this pull request as draft April 3, 2025 06:54
@akoch-yatta akoch-yatta force-pushed the always-use-fontprovider branch from 44a95ca to 21bf53f Compare April 3, 2025 10:39
This commit unifies the extraction of the target zoom of a font to be
affected by the zoom context of the underlying Widget. Before there
were different strategies like getting it from the Shell.
@akoch-yatta akoch-yatta force-pushed the always-use-fontprovider branch from 21bf53f to be9b308 Compare April 3, 2025 10:42
@akoch-yatta akoch-yatta changed the title [win32] Prefer SWTFontProvider over Font#win32_new [win32] Use consistent font zoom retrieval Apr 3, 2025
@akoch-yatta akoch-yatta marked this pull request as ready for review April 3, 2025 11:11
@akoch-yatta akoch-yatta linked an issue Apr 4, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent font zoom retrieval
1 participant