Skip to content

Add getGcStyle() method to accommodate styling #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Add getGcStyle() method to accommodate styling #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.cocoa.macosx.aarch64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,14 @@
<message_argument value="VerifyKeyListener"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT Drag and Drop/common/org/eclipse/swt/dnd/DragSourceListener.java" type="org.eclipse.swt.dnd.DragSourceListener">
<filter id="576720909">
Expand Down
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.cocoa.macosx.x86_64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,14 @@
<message_argument value="VerifyKeyListener"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT Drag and Drop/common/org/eclipse/swt/dnd/DragSourceListener.java" type="org.eclipse.swt.dnd.DragSourceListener">
<filter id="576720909">
Expand Down
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.gtk.linux.aarch64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,14 @@
<message_argument value="VerifyKeyListener"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT Drag and Drop/common/org/eclipse/swt/dnd/DragSourceListener.java" type="org.eclipse.swt.dnd.DragSourceListener">
<filter id="576720909">
Expand Down
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.gtk.linux.loongarch64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,14 @@
<message_argument value="VerifyKeyListener"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT Drag and Drop/common/org/eclipse/swt/dnd/DragSourceListener.java" type="org.eclipse.swt.dnd.DragSourceListener">
<filter id="576720909">
Expand Down
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.gtk.linux.ppc64le/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,14 @@
<message_argument value="VerifyKeyListener"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT Drag and Drop/common/org/eclipse/swt/dnd/DragSourceListener.java" type="org.eclipse.swt.dnd.DragSourceListener">
<filter id="576720909">
Expand Down
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.gtk.linux.riscv64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,14 @@
<message_argument value="VerifyKeyListener"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT Drag and Drop/common/org/eclipse/swt/dnd/DragSourceListener.java" type="org.eclipse.swt.dnd.DragSourceListener">
<filter id="576720909">
Expand Down
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.gtk.linux.x86_64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@
<message_argument value="NO_SEARCH"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF">
<filter id="926941240">
Expand Down
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.win32.win32.aarch64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,14 @@
<message_argument value="VerifyListener"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageLoaderListener.java" type="org.eclipse.swt.graphics.ImageLoaderListener">
<filter id="576720909">
Expand Down
8 changes: 8 additions & 0 deletions binaries/org.eclipse.swt.win32.win32.x86_64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,14 @@
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java" type="org.eclipse.swt.graphics.ImageGcDrawer">
<filter id="404000815">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageGcDrawer"/>
<message_argument value="getGcStyle()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageLoaderListener.java" type="org.eclipse.swt.graphics.ImageLoaderListener">
<filter id="576720909">
<message_arguments>
Expand Down
13 changes: 13 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/ImageGcDrawer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
*******************************************************************************/
package org.eclipse.swt.graphics;

import org.eclipse.swt.*;

/**
* Interface to provide a callback mechanism to draw on different GC instances
* depending on the zoom the image will be used for. A common use case is when
Expand Down Expand Up @@ -45,4 +47,15 @@ public interface ImageGcDrawer {
default void postProcess(ImageData imageData) {
}

/**
* Returns the GC style used when creating the GC instance. Default
* implementation returns <code>SWT.NONE</code>.
*
* @return the GC style constant
*
* @since 3.130
*/
default int getGcStyle() {
return SWT.NONE;
}
}
2 changes: 1 addition & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2502,7 +2502,7 @@ ImageData getImageData(int zoom) {
ImageHandle getImageMetadata(int zoom) {
initialNativeZoom = zoom;
Image image = new Image(device, width, height, zoom);
GC gc = new GC(image);
GC gc = new GC(image, drawer.getGcStyle());
try {
gc.data.nativeZoom = zoom;
drawer.drawOn(gc, width, height);
Expand Down
Loading