Implement service authentication using SASL EXTERNAL mechanism #3710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
requested review from
dejanb,
kaniyan and
sophokles73
as code owners
Contributor
|
Thanks for the PR 👍 This is certainly a nice improvement and I will be glad to add it once we have upgraded to the corresponding version of Quarkus that contains vertx 4.5.22. We try to stick as closely as possible to the library versions determined by Quarkus as it is the basic application framework that Hono builds upon. Again, thanks a lot for your contribution :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of version
4.5.22of thevertx-protonpackage. It's now possible to set the authorization ID of the amqp SASL authentication. This PR implements authentication with the SASL External mechanism, by setting the authorization ID when connecting to the remote authentication server.Additionally, the authentication is changed to fail instead of continuing without impersonation when the user isn't allowed to impersonate. This makes debugging easier.