Stream methods implementation #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…created test for these methods Signed-off-by: Anton Pinsky <[email protected]>
Signed-off-by: Anton Pinsky <[email protected]>
…corrections afterward Signed-off-by: Anton Pinsky <[email protected]>
…P Parser in it & JsonParserImpl; higher code coverage Signed-off-by: Anton Pinsky <[email protected]>
Signed-off-by: Anton Pinsky <[email protected]>
|
Anybody would like to take a look on this, to review and merge at the end? |
Merged
|
done through #124 |
|
reverted the change in #126 because b7a2278 breaks testGetValueStream test in TCK |
I'll take a look. Just have to upmegre the changes from main. How could I run the TCK tests locally? And with changes from the branch? I have to take a look at the tests to understand this. Can I see the error messages from the failed test run somewhere? |
|
TCK is available here, unzip it, edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the stream and skip methods for Yasson. See this and this. Then I saw that these things are also missing in some parser realizations of Parsson. So I just port this here, because my implementation is based on the JParser interface itself.
StreamCreator is here only because of Java 8 compatibility.
Another off-topic question: I have many PR for Yasson, and they are unreviewed. Is there anybody else who can review them? Or any other way to get them closer to be merged. Theses are the bugs and missing functions.