Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Doc about installing ImagePuller #2835

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: Doc about installing ImagePuller #2835

merged 2 commits into from
Dec 12, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 12, 2024

What does this pull request change?

fix: Doc about installing ImagePuller

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/CRW-7865

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@tolusha tolusha marked this pull request as ready for review December 12, 2024 10:59
@tolusha tolusha requested review from deerskindoll and a team as code owners December 12, 2024 10:59
@tolusha tolusha requested a review from nickboldt December 12, 2024 10:59
Copy link

github-actions bot commented Dec 12, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Dec 12, 2024

🎊 Navigate the preview: https://675b0aecd4750b1f06159845--eclipse-che-docs-pr.netlify.app 🎊

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small tweak

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tolusha
Copy link
Contributor Author

tolusha commented Dec 12, 2024

Some tests fails, can I merge anyway ?

@deerskindoll
Copy link
Contributor

Some tests fails, can I merge anyway ?

please cherry-pick this PR: #2836

it solves the issue with the failing htmltest

@tolusha tolusha merged commit 9c85cf4 into main Dec 12, 2024
10 checks passed
@tolusha tolusha deleted the CRW-7865 branch December 12, 2024 16:10
deerskindoll pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants