Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Using https://open-vsx.org with thousands of community-supported extensions is not recommended in an air-gapped environment #2832

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Dec 3, 2024

What does this pull request change?

Screenshot 2024-12-03 at 15 16 46

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

…d extensions is not recommended in an air-gapped environment

Signed-off-by: Ilya Buziuk <[email protected]>
@ibuziuk ibuziuk requested review from deerskindoll and a team as code owners December 3, 2024 14:16
@ibuziuk ibuziuk requested review from l0rd and svor December 3, 2024 14:16
Copy link

github-actions bot commented Dec 3, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Dec 3, 2024

🎊 Navigate the preview: https://6756d2fb2f08e7f534720a33--eclipse-che-docs-pr.netlify.app 🎊

@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 3, 2024

@deerskindoll once merged, please backport to 7.95.x for 3.18

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small tweak

====
[IMPORTANT]
====
* Using link:https://open-vsx.org[https://open-vsx.org] with thousands of community-supported extensions is not recommended in an air-gapped environment, isolated from the internet. In order to reduce the risk of malware infections and unauthorized access to your code use the embedded or self-hosted Open VSX registry with the curated set of extensions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Using link:https://open-vsx.org[https://open-vsx.org] with thousands of community-supported extensions is not recommended in an air-gapped environment, isolated from the internet. In order to reduce the risk of malware infections and unauthorized access to your code use the embedded or self-hosted Open VSX registry with the curated set of extensions.
* Using the extensions from link:https://open-vsx.org[https://open-vsx.org] is not recommended in an air-gapped environment, isolated from the internet. In order to reduce the risk of malware infections and unauthorized access to your code use the embedded or self-hosted Open VSX registry with the curated set of extensions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, I like the original version more

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially, we can remove with thousands of community-supported extensions part, but the main point here is about registry itself (https://open-vsx.org in the CR), not individual extentions

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ibuziuk ibuziuk requested a review from mbenitez1607 December 3, 2024 14:40
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ibuziuk ibuziuk merged commit a0b1219 into eclipse-che:main Dec 4, 2024
6 checks passed
deerskindoll pushed a commit that referenced this pull request Dec 4, 2024
…d extensions is not recommended in an air-gapped environment (#2832)

* docs: Using https://open-vsx.org with thousands of community-supported extensions is not recommended in an air-gapped environment

Signed-off-by: Ilya Buziuk <[email protected]>

* Update modules/administration-guide/partials/proc_selecting-an-open-vsx-registry-instance.adoc

---------

Signed-off-by: Ilya Buziuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants