Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update autoscaler documentation #2789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: update autoscaler documentation #2789

wants to merge 2 commits into from

Conversation

mkuznyetsov
Copy link
Contributor

What does this pull request change?

Update autoscaling documentation, as there will be no need to change ignoredUnrecoverableEvents anymore. PR is related to these changes eclipse-che/che-operator#1897

What issues does this pull request fix or reference?

devfile/devworkspace-operator#1280

Specify the version of the product this pull request applies to

7.92.0

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Mykhailo Kuznietsov <[email protected]>
Copy link

github-actions bot commented Sep 9, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Sep 9, 2024

🎊 Navigate the preview: 🎊

@tolusha
Copy link
Contributor

tolusha commented Sep 10, 2024

@ibuziuk
Could you confirm, that FailedScheduling event should be configured by default independently of autoscaler existence?

@mkuznyetsov mkuznyetsov marked this pull request as ready for review September 10, 2024 14:06
@ibuziuk
Copy link
Member

ibuziuk commented Sep 10, 2024

@mkuznyetsov @AObuchow I believe since the aproach is now creating default DWOC with FailedScheduling set ignored by default, we should probably still have it in the docs just add a note that it will be set automatically

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deerskindoll
Copy link
Contributor

the build and validate pr pipeline is failing because this site can't be reached: https://www.gnu.org/software/coreutils/base64

should I add it to the ignorelist for the htmltest?

@mkuznyetsov
Copy link
Contributor Author

@deerskindoll after rerunning the checks, they are now passing 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants