Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #272

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Update README.md #272

merged 1 commit into from
Mar 4, 2025

Conversation

CrypticError
Copy link
Contributor

Fixed the example, previously it was referring to biscuit, the module, instead of biscuit2, the variable.

Fixed the example, previously it was referring to biscuit, the module, instead of biscuit2, the variable.
@divarvel
Copy link
Collaborator

divarvel commented Feb 27, 2025

Thanks!

The failure on the codspeed benchmarks is unrelated, and benchmarks are not affected by your change anyways.

The only missing bit is the Eclipse Contributor Agreement check, you can sign it once you have created an eclipse account https://accounts.eclipse.org/user/register

to be clear, this is not a CLA:

The purpose of the Eclipse Contributor Agreement (ECA) is to provide a written record that contributors have agreed to provide their contributions of code and documentation under the licenses used by the Eclipse project(s) they’re contributing to. It also makes it clear that contributors are promising that what they are contributing to Eclipse is code that they wrote, and that they have the necessary rights to contribute it to Eclipse projects. And finally, it documents a commitment from the contributor that their open source contributions will be permanently on the public record.

@divarvel divarvel merged commit cb8cec2 into eclipse-biscuit:main Mar 4, 2025
4 of 5 checks passed
@divarvel
Copy link
Collaborator

divarvel commented Mar 4, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants