-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pem/der loaders to PublicKey #265
Conversation
Expose pem feature in biscuit-parser crate as well
CodSpeed Performance ReportMerging #265 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 67.23% 68.61% +1.38%
==========================================
Files 39 39
Lines 7407 7424 +17
==========================================
+ Hits 4980 5094 +114
+ Misses 2427 2330 -97 ☔ View full report in Codecov by Sentry. |
yes, that would be great to have PEM support for both algorithms and for private and public keys |
9dc0132
to
18b0533
Compare
…ivate keys The pem/der payloads contain information about the key algorithm. Unfortunately we can’t easily extract it ahead of time, but we can try for each supported algorithms. Key parsing is typically a one-time operation, so it’s ok to do it this way.
18b0533
to
d443e17
Compare
rebase of #212 over main
PEM key loading is only supported for ed25519 right now (so the relevant methods on the common KeyPair etc types are removed). Do we add it for p256 curves?