Add support for StakeAddress and BaseAddress output - #46
Conversation
|
@safanaj it was too late when I finished implementing StakeAddress management on my own and later found out you've done similar work in #41 PR... |
|
@echovl Could you allow few more people to review PRs and have write access to the repo so that they can merge PRs as well? Hope this repo to be a bit more responsive and prosper :) |
Agree, yes I will. Only I saw that on my PR in address.go there are 2 typo fixes in the NewAddressFromBytes constructor, regarding the error message for Ptr address type if those make sense to you too add them. @echovl if you are still short with time probably as suggested by @kevink1103 you could allow us to review and merge. |
|
Hi guys, sorry for the late reply, this looks good to me. Do we really need the bech32 PR merged first? |
|
Just to follow up on this PR. For those who are interested in this PR, use the forked one! |
This PR includes:
Wallet.Addresses()and replace it withWallet.EnterpriseAddresses()Wallet.Keys()and replace it withWallet.PrvKeys()Wallet.BaseAddresses()StakeAddresssupport forAddressandWalletPoolCostinpoolRegistrationstructcloses #45
closes #20