Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client_id and client_secret explicitly to session.post() #1106

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

ecederstrand
Copy link
Owner

To work around token refresh bug. Fixes #1090

@cmin764
Copy link

cmin764 commented Aug 9, 2022

There's a test failing I see, is it flaky?

test_wrap (tests.test_transport.TransportTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/exchangelib/exchangelib/tests/test_transport.py", line 98, in test_wrap
    PrettyXmlHandler.prettify_xml(wrapped),
  File "/home/runner/work/exchangelib/exchangelib/exchangelib/util.py", line 584, in prettify_xml
    lxml.etree.tostring(cls.parse_bytes(xml_bytes), xml_declaration=True, encoding="utf-8", pretty_print=True)
TypeError: parse_bytes() missing 1 required positional argument: 'xml_bytes'


....


test_pretty_xml_handler (tests.test_util.UtilTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/exchangelib/exchangelib/tests/test_util.py", line 222, in test_pretty_xml_handler
    "hello \x1b[36m<?xml version='1.0' encoding='utf-8'?>\x1b[39;49;00m\n\x1b[94m"
AssertionError: 'hello b\'<?xml version="1.0" encoding="UTF-8"?><foo>bar</foo>\'\n' != "hello \x1b[36m<?xml version='1.0' encoding='utf-8'?>\x1b[39;49;00m\n\x1b[94m<foo\x1b[39;49;00m\x1b[94m>\x1b[39;49;00mbar\x1b[94m</foo>\x1b[39;49;00m\n"
- hello b'<?xml version="1.0" encoding="UTF-8"?><foo>bar</foo>'
+ hello <?xml version='1.0' encoding='utf-8'?>
+ <foo>bar</foo>

@ecederstrand
Copy link
Owner Author

That was me botching the master branch with 2a1cb32 :-( I just committed a fix.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.651% when pulling 6675d82 on 1090-fix-token-refresh into 6faeea4 on master.

@ecederstrand ecederstrand merged commit 2672ff9 into master Aug 9, 2022
@ecederstrand ecederstrand deleted the 1090-fix-token-refresh branch August 9, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expired OAuth token refreshing endless loop
3 participants