Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve schedule entry picker #6997

Merged

Conversation

manuelmeister
Copy link
Member

Before After
Bildschirmfoto 2025-03-08 um 17 07 13 Bildschirmfoto 2025-03-08 um 17 06 32

I had to fix the timefield, as it ignored the day given and instead used today.

@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Mar 8, 2025
Copy link

github-actions bot commented Mar 8, 2025

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@manuelmeister manuelmeister marked this pull request as draft March 8, 2025 22:22
@manuelmeister manuelmeister marked this pull request as ready for review March 9, 2025 10:50
@manuelmeister manuelmeister requested a review from a team March 9, 2025 10:50
@pmattmann
Copy link
Member

I like.

Two questions / suggestions:

  • Why don't we always show the date field? I think we may differ from Google Calendar here. Google calendar is aimed at everyday life (many appointments shorter than 1 day). eCamp is aimed at Y+S camps - in which there are probably more frequent multi-day blocks.
    If you want to create a block over several days, you have to 'click through': Long duration, so that the date appears, then select date and time.

  • Always show duration (e.g. 1h 30min, 22h, 2days 3h 30min)
    Not only if the block ends on the same day.

Request:

  • Dropdown with duration should show currently selected duration (it should be scrolled there)

image

@manuelmeister
Copy link
Member Author

manuelmeister commented Mar 16, 2025

@pmattmann
I thought that the average (even activity distinct) duration is between 30min and 4h. So I just checked the database and the data agrees:

Bildschirmfoto 2025-03-16 um 22 16 38
Bildschirmfoto 2025-03-16 um 22 53 22

That's the reason I hid the endDate field, as it clutters the view.

As for the duration, I thought that if an activity is longer than 1 day, it is probably much less relevant how long it is as the night is usually not as important.

As for the scroll into view, I agree with you! The problem is that this would just work if it was a v-select, but this is a textfield (even a parse field) and a v-menu. I agree that it would be much nicer to automatically scroll to the current selected time, but this requires a bit more (or even deep interference with vuetify) which I thought is more of a nice to have, as the PR already improves the situation greatly.

@manuelmeister
Copy link
Member Author

eCamp Core Decision

  • Need to research mobile (but probably be the same as Google Calendar or iPhone Calendar on mobile)
  • Desktop:
    • adjust timefield dropdown to match google calendar
    • show duration always
  • try to fix the scrollto

@manuelmeister manuelmeister marked this pull request as draft March 18, 2025 20:12
@manuelmeister manuelmeister marked this pull request as ready for review March 20, 2025 19:02
@manuelmeister manuelmeister requested a review from pmattmann March 20, 2025 19:02
@manuelmeister manuelmeister requested review from a team and BacLuc March 21, 2025 07:29
grid-template-columns: auto auto 1fr;
}

@media (min-width: 768px) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you repeat @media (min-width: 768px) { on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought it makes more sense to keep the different media breakpoints of a class close to the mobile definition

@BacLuc
Copy link
Contributor

BacLuc commented Mar 22, 2025

I found some behavior which seems strange to me:
Screencast from 2025-03-22 15-36-36.webm

Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its on purpose that the end time changes when you change the start time, and the duration stays constant.

I would the smaller issues (leftover console log and so) to be fixed, else it looks good.
And mobile is a little off.

class="area-enddate float-left date-picker mr-3 mt-md-1"
required
/>
<e-text-field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

this is a little off on mobile

@manuelmeister manuelmeister requested a review from BacLuc March 22, 2025 16:27
@manuelmeister manuelmeister requested a review from a team March 22, 2025 16:27
@manuelmeister manuelmeister added this pull request to the merge queue Mar 22, 2025
Merged via the queue into ecamp:devel with commit 3e92e4d Mar 22, 2025
30 checks passed
@manuelmeister manuelmeister deleted the feature/improve-scheduleEntry-picker branch March 22, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants