-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve schedule entry picker #6997
Improve schedule entry picker #6997
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
I like. Two questions / suggestions:
Request:
|
@pmattmann That's the reason I hid the endDate field, as it clutters the view. As for the duration, I thought that if an activity is longer than 1 day, it is probably much less relevant how long it is as the night is usually not as important. As for the scroll into view, I agree with you! The problem is that this would just work if it was a |
eCamp Core Decision
|
frontend/src/components/activity/dialog/FormScheduleEntryItem.vue
Outdated
Show resolved
Hide resolved
grid-template-columns: auto auto 1fr; | ||
} | ||
|
||
@media (min-width: 768px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you repeat @media (min-width: 768px) { on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought it makes more sense to keep the different media breakpoints of a class close to the mobile definition
I found some behavior which seems strange to me: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its on purpose that the end time changes when you change the start time, and the duration stays constant.
I would the smaller issues (leftover console log and so) to be fixed, else it looks good.
And mobile is a little off.
class="area-enddate float-left date-picker mr-3 mt-md-1" | ||
required | ||
/> | ||
<e-text-field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to fix the timefield, as it ignored the day given and instead used today.