Revert to working Datagroup construction #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed unexpected line insertions
Amended the calculation of DirectorySize at line 186 to include the 13 bytes of the Directory header plus whatever bytes are used by the Directory Parameters.
Update to support python3 / remove dependency on a specific version of bitarray
Added the possibility to add padding packets to make sure the final packet continuity index value is always 3
This approach ensures the correct sequence of the packet continuity index by repeating the generation of the packet stream until it ends with Continuity Index =3. That means it may produce a file twice or four-times bigger than normal, if padding is enabled.
Add Continuity Index parameter
Adjusts the calculation of the continuity index to increment on every datagroup, not just within datagroups of the same object
Merge pull request #1 from nickpiggott/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit altered the way Datagroups were compiled, and apparently broke them.
This version has been tested on the Bristol Trial DAB multiplex, and creates an SPI stream that can be decoded correctly.