Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for CRAN #405

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Prepare for CRAN #405

merged 3 commits into from
Dec 3, 2023

Conversation

rempsyc
Copy link
Member

@rempsyc rempsyc commented Nov 25, 2023

Updated snapshots to fix failing tests

@IndrajeetPatil IndrajeetPatil linked an issue Dec 2, 2023 that may be closed by this pull request
@rempsyc
Copy link
Member Author

rempsyc commented Dec 3, 2023

I am getting 0 errors ✔ | 0 warnings ✔ | 0 notes ✔ locally on Windows, but on ubuntu-latest (oldrel-3), there is an error running examples from format_algorithm():

> library(lme4)
Loading required package: Matrix
> model <- lme4::lmer(Sepal.Length ~ Sepal.Width + (1 | Species), data = iris)
Error in initializePtr() : 
  function 'cholmod_factor_ldetA' not provided by package 'Matrix'

Which also leads to an error when building the corresponding vignette. Is it safe to ignore @IndrajeetPatil ?

Test coverage is also failing but errors from this check are often obscure so I don't know where it is coming from.

Running specific tests for package 'report'
  Running 'testthat.R'
Error: Error: Failure in `C:/Users/runneradmin/AppData/Local/Temp/RtmpcRyM1q/R_LIBSfac68661d[63](https://github.com/easystats/report/actions/runs/7073622001/job/19253772373?pr=405#step:6:64)/report/report-tests/testthat.Rout.fail`
      │ └─base::eval(expr, envir)
 14.               │   └─base::eval(expr, envir)
 15.               └─brms::do_call(rstan::stan_model, args)
 16.                 └─brms:::eval2(call, envir = args, enclos = envir)
 17.                   └─base::eval(expr, envir, ...)
 18.                     └─base::eval(expr, envir, ...)
 19.                       └─rstan (local) .fun(model_code = .x1)

check-random-test-order is also failing for test-report.brmsfit.R, but I am not sure how this check works. I thought it tested each test_that() units in a random order, but in this case, there is a single call to test_that(), so how can it fail?

Copy link
Member

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore the build failures for now.

The lme4 just needs to be installed from source.
The other issues are also probably platform-specific and can be put aside for now.

@rempsyc rempsyc merged commit 652cebc into main Dec 3, 2023
23 of 26 checks passed
@rempsyc rempsyc deleted the cran_prep1 branch December 3, 2023 13:46
@rempsyc
Copy link
Member Author

rempsyc commented Dec 3, 2023

Thanks! Preparing to send to CRAN

@rempsyc
Copy link
Member Author

rempsyc commented Dec 3, 2023

I am not able to test revdepcheck, it seems it is always skipped, even when I want to trigger it manually. I think I remember the commit must include rc or something? I think file the file should include the proper command to include in the commit so we can easily refer to it in the future: https://github.com/easystats/workflows/blob/main/.github/workflows/revdepcheck.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CRAN release?
2 participants