-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for friedman test #390
Conversation
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 72.25% 72.48% +0.23%
==========================================
Files 47 48 +1
Lines 3316 3391 +75
==========================================
+ Hits 2396 2458 +62
- Misses 920 933 +13
|
Some of the tests are again failing because of a .01 difference in value in snapshots between local and GA checks... Kind of annoying having to modify them by hand to match GitHub values, maybe skipping those tests is better? What's your opinion @IndrajeetPatil ? |
The difference in values comes from R-release vs R-devel? In that case, you can skip the offending case on the R-devel. |
It seems that it fails even on release, check random test order, and test coverage, so not only devel... |
Ok for some reasons the snapshots were not updating locally so deleted them and ran the tests again and now it seems fixed :) |
There is only test coverage that is failing but I don't understand this error since it does not come up on other checks.
|
addresses #309 part 2 (friedman test)
This fixes
report(chisq.test)
andreport(friedman.test)
, which were both broken.Created on 2023-08-27 with reprex v2.0.2