Skip to content

Interface factory unit tests #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Interface factory unit tests #151

wants to merge 11 commits into from

Conversation

@rozyczko
Copy link
Member

@rozyczko rozyczko commented Oct 16, 2025

This class had ZERO unit test coverage. Now we have it covered.

Also, added codecov.

For this branch, check out
https://app.codecov.io/gh/EasyScience/corelib/tree/interface_factory_unit_tests

github-actions[bot]
github-actions bot requested changes Oct 16, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@rozyczko rozyczko added chore PR label [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] medium Normal/default priority labels Oct 16, 2025
@rozyczko
Copy link
Member Author

rozyczko commented Oct 16, 2025

The current unit test coverage is a bit over 75%. Need to improve that to at least 80%

@codecov
Copy link

codecov bot commented Oct 16, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@rozyczko rozyczko marked this pull request as draft October 17, 2025 08:29
@rozyczko
Copy link
Member Author

rozyczko commented Oct 17, 2025

It's 79.71% 💀
I'm stopping here

@rozyczko rozyczko marked this pull request as ready for review October 17, 2025 09:37
henrikjacobsenfys
henrikjacobsenfys reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@henrikjacobsenfys henrikjacobsenfys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the interface factory and global object, but it looks good to me. I have only two minor comments/questions.

@damskii9992
Copy link
Contributor

damskii9992 commented Oct 28, 2025

Shouldn't this PR go into develop? Why is it going into Master?

@rozyczko
Copy link
Member Author

rozyczko commented Oct 28, 2025

Shouldn't this PR go into develop? Why is it going into Master?

because I'm a blind numpty. Fixed.

@rozyczko rozyczko changed the base branch from master to develop October 28, 2025 14:20
@rozyczko rozyczko mentioned this pull request Nov 4, 2025
Closed
@rozyczko
Copy link
Member Author

rozyczko commented Nov 4, 2025

80.23%. There we go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrikjacobsenfys henrikjacobsenfys henrikjacobsenfys left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

chore PR label [priority] medium Normal/default priority [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rozyczko @damskii9992 @henrikjacobsenfys