Skip to content

fixed the behaviour of full_value() getter #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

fixed the behaviour of full_value() getter #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/easyscience/variable/parameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,6 @@ def full_value(self) -> Variable:

:return: Value of self with unit and variance.
"""
if self._callback.fget is not None:
scalar = self._callback.fget()
if scalar != self._scalar:
self._scalar = scalar
return self._scalar

@full_value.setter
Expand Down
4 changes: 3 additions & 1 deletion tests/unit_tests/variable/test_parameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,14 +635,16 @@ def test_set_value_dependent_parameter(self, normal_parameter: Parameter):
with pytest.raises(AttributeError):
dependent_parameter.value = 3

@pytest.mark.skip(reason="No longer relevant")
def test_full_value_match_callback(self, parameter: Parameter):
# When
self.mock_callback.fget.return_value = sc.scalar(1, unit='m')

# Then Expect
assert parameter.full_value == sc.scalar(1, unit='m')
assert parameter._callback.fget.call_count == 1


@pytest.mark.skip(reason="No longer relevant")
def test_full_value_no_match_callback(self, parameter: Parameter):
# When
self.mock_callback.fget.return_value = sc.scalar(2, unit='m')
Expand Down
Loading