Skip to content

Conversation

@rozyczko
Copy link
Member

Fixed the RuntimeError: dictionary changed size during iteration issue in the vertices method by implementing thread-safety: iterations handling modifications during garbage collection.
This seems to have been a concurrency problem with weak references, where the dictionary is being modified during iteration.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) bugfix PR label [priority] high Should be prioritized soon labels Sep 19, 2025
@rozyczko rozyczko changed the base branch from master to develop September 19, 2025 06:44
@rozyczko rozyczko marked this pull request as ready for review September 19, 2025 11:06
@rozyczko
Copy link
Member Author

rozyczko commented Oct 3, 2025

Nope. More work needed.

Take the attached script (.txt -> .py cause GitHub)
run_test_suite.txt
Run it in say, EasyReflectometryLib and see that it fails for master branch but it also fails for this branch (albeit fewer failures on average).

@rozyczko rozyczko marked this pull request as draft November 3, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR label [priority] high Should be prioritized soon [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants