Changed add_vertex behaviour on identical unique name #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We throw on creating a new map vertex if the parameter has the same unique name.
This makes sense when a typical job is being run.
However, in a multiprocessing environment, we can't guarantee this behaviour, especially considering the
global_object
is a singleton and will be the same across the CPU pool.One solution would be to allow multiple copies of
global_object
in MPI, but this seems a complex and error prone (at least at the moment). The alternative is to modify the unique name if it clashes with one in the map.This is what I am proposing here.