Add model_selector_open extension event#4824
Open
julien-c wants to merge 2 commits into
Open
Conversation
Emitted (fire-and-forget) from showModelSelector before opening the picker. Extensions can refresh provider state on this event; updates land on the next picker open, not the current one. Co-Authored-By: julien-agent <Agents+cyolo@huggingface.co>
Co-Authored-By: julien-agent <Agents+cyolo@huggingface.co>
Collaborator
|
making it non-blocking is not the way to go here, i think. i have to review the llama.cpp PR first before deciding on this one. probably sometime next week, busy with lots of stuff :) |
Contributor
Author
|
(another option is to keep the event non-blocking but make the modelRegistry UI reactive to changes in the model list) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New extension event fired when the interactive model picker opens. Lets extensions refresh provider state (e.g. re-fetch a remote model list) on demand.
Currently dispatched fire-and-forget so the UI doesn't block — handler updates land on the next picker open. Open question: should we
awaitinstead so the picker reflects refreshed data immediately, at the cost of briefly blocking the open on extension handlers?