feat(coding-agent): fetch portable git bash on windows#4651
Conversation
|
Please don't, at least not by default and not without asking. I can already see cases of pi not detecting Git bash (or other bash) installed in a non standard location and downloading another copy. Also, many Windows installations in corporate environments are locked down, so installing won't work anyways. A better approach would be to just check for the required tools, and then ask the user if they want them to be installed automatically, or if they want to provide a path to an already installed tool. |
Given how pi works today, in that case pi does not work. They are hooked up to the same path.
That then also affects ripgrep and fd which we also already download today. |
|
Interesting! I think it can also be implemented via plugins, and recommended official plugins can be listed in the README. |
|
@mitsuhiko rg and fd downloads fail gracefully and a small dependencies. msys is 350mb. i propose this: our install script can offer the user to setup msys2/git bash if it finds its absent. the tricky part is that Windows users may not install via curl | sh :) |
|
Anyone considered Busybox? https://frippery.org/busybox/ |
|
@marcfargas i have indeed. Unfortunately it's shell is quite more restricted to what agents love to invoke so I'm not entirely clear if that is a good tradeoff. |
Proposal:
Then on next release you can ask windows users to test !!! I will report my findings on busybox nonetheless, git bash and complex pipes is miserable anyway |
This comment was marked as low quality.
This comment was marked as low quality.
|
You are banned @Randy-sin |
|
This PR got me thinking about the git bash problem from a different angle. pi already has a clean pattern: every tool has an
A thin The core tools stay exactly as they are — four tools, same structured output, same agent experience. They just call For this PR specifically: For pi maintainers this means: It's a small layer. Just giving a name to what pi's tools already assume — that there's a shell and a filesystem underneath. |
This is an experiment to automatically download git bash like we do for rg and find on windows. However it will unpack around 350MB of things into
~/.piso it's not clear we actually want this.I am leaving this on a draft PR for a little while until I get an idea of if this is something we want to entertain.