-
Notifications
You must be signed in to change notification settings - Fork 1
21 referencing a workflow crate #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@elichad @douglowe @stain @alexhambley I think this PR is ready for review. |
| @prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
|
|
||
|
|
||
| five-safes-crate::DatasetMustHaveDistributionIfURI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be single colon :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| sh:message "The mainEntity pointed to by the RootDataEntity MUST be of type schema:Dataset" ; | ||
| ] . | ||
|
|
||
| five-safes-crate:mainEntityHasProperConformsTo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure, but I think this may only validate the prefix when conformsTo exists. In other words if conformsTo is missing, the violation might not report (?)
sh:minCount 1 ; might be required. Worth a test to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Added a constraint for that and a corresponding test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided comments in-line. There is a double colon typo and conformsTo property needs checking :)
|
This is superceded by PR #28 |
Rules implemented
Rules NOT implemented
There are other rules pertaining to the mainEntity, but these were deemed to be not implementable.
For sake of completeness these are reported below